Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: integrate sendTransaction endpoint #18120

Closed
wants to merge 2 commits into from

Conversation

briansztamfater
Copy link
Member

fixes #...

Summary

This PR integrates send transaction endpoint with transaction confirmation page

Review notes

Steps to test

  • Open Status
  • Open new wallet
  • Open account
  • Select Send
  • Select an address
  • Select a token
  • Input a valid amount and wait for a route to be available
  • Tap continue button
  • Check transaction confirmation page
  • Swipe and input password to execute transaction. Check on Etherscan or other explorer to confirm the transaction execution, as transaction status page is not available yet

status: wip

Signed-off-by: Brian Sztamfater <brian@status.im>
Signed-off-by: Brian Sztamfater <brian@status.im>
@briansztamfater briansztamfater added the feature feature requests label Dec 8, 2023
@briansztamfater briansztamfater self-assigned this Dec 8, 2023
@briansztamfater briansztamfater marked this pull request as draft December 8, 2023 03:41
@status-im-auto
Copy link
Member

status-im-auto commented Dec 8, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
b5a48dc #1 2023-12-08 03:45:18 ~3 min tests 📄log
✔️ b5a48dc #1 2023-12-08 03:48:56 ~7 min android-e2e 🤖apk 📲
✔️ b5a48dc #1 2023-12-08 03:49:03 ~7 min android 🤖apk 📲
✔️ b5a48dc #1 2023-12-08 03:54:50 ~13 min ios 📱ipa 📲
✔️ b5a48dc #2 2023-12-19 11:06:47 ~6 min android-e2e 🤖apk 📲
✔️ b5a48dc #2 2023-12-19 11:11:53 ~11 min android 🤖apk 📲
b5a48dc #2 2023-12-19 11:12:08 ~11 min tests 📄log
✔️ b5a48dc #2 2023-12-19 11:13:49 ~13 min ios 📱ipa 📲

@briansztamfater briansztamfater force-pushed the feat/suggested-routes branch 11 times, most recently from 1d63ee8 to 21dcda2 Compare December 15, 2023 17:52
@J-Son89 J-Son89 force-pushed the feat/suggested-routes branch 3 times, most recently from 05fd97e to e541a2a Compare December 19, 2023 10:47
Base automatically changed from feat/suggested-routes to develop December 19, 2023 11:00
@briansztamfater
Copy link
Member Author

Implemented in #18242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants