Community Request to Join - Show Addresses to share Cards #18123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
ajayesivan
force-pushed
the
17977-show-addresses
branch
from
f640d37 to
f9d1f4f
Compare
ilmotta
reviewed
Dec 8, 2023
| [quo/category | ||
| {:list-type :settings | ||
| :data [{:title (i18n/label :t/join-as-a-member) | ||
| :on-press #(print "Show All Addresses Sheet") |
There was a problem hiding this comment.
To keep the code consistent, we use js/alert. But even better would be status-im2.common.not-implemented/alert.
| :label :preview | ||
| :label-props {:type | ||
| :accounts | ||
| :data (subvec account-list 0 1)} |
There was a problem hiding this comment.
You can probably use (take 1 account-list)
| :label-props {:type | ||
| :accounts | ||
| :data (subvec account-list 0 1)} | ||
| :description-props {:text (:name (account-list 0))}}]}] |
There was a problem hiding this comment.
It's dangerous to access vectors like this. At least in Clojure JVM you get index out of bounds if the collection is empty.
Best is (-> account-list first :name)
Edit: In ClojureScript we get:
(let [v []]
(v 0)) ; => Exception: No item 0 in vector of length 0| vals | ||
| (map #(assoc % :customization-color (:color %))) | ||
| vec)] | ||
| (tap> account-list) |
| {:keys [name color images]} (rf/sub [:communities/community id])] | ||
| {:keys [name color images]} (rf/sub [:communities/community id]) | ||
| {:keys [accounts]} (rf/sub [:wallet]) | ||
| account-list (->> accounts |
There was a problem hiding this comment.
Do we really need account-list to be an instance of PersistentVector? I saw that label-props is used with the Clojure's for macro, so it can be any sequence.
|
@ilmotta Thank you for the review. I have updated the code please have another look. |
ilmotta
approved these changes
Dec 8, 2023
| [quo/category | ||
| {:list-type :settings | ||
| :data [{:title (i18n/label :t/join-as-a-member) | ||
| :on-press #(not-implemented/alert) |
There was a problem hiding this comment.
We can pass the function without wrapping it on an anonymous one.
FFFra
approved these changes
Dec 8, 2023
| :action :arrow | ||
| :label :preview | ||
| :label-props {:type | ||
| :accounts |
There was a problem hiding this comment.
Should this be in the same line? :type :accounts
| :action :arrow | ||
| :label :preview | ||
| :label-props {:type | ||
| :accounts |
ajayesivan
force-pushed
the
17977-show-addresses
branch
2 times, most recently
from
0ff6540 to
a2f83c6
Compare
51% of end-end tests have passedFailed tests (19)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (25)Click to expandClass TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
yqrashawn
approved these changes
Dec 11, 2023
ajayesivan
force-pushed
the
17977-show-addresses
branch
from
a2f83c6 to
4d2bb37
Compare
|
@status-im/mobile-qa This pull request doesn't necessitate manual testing as the modifications are implemented under a feature flag, currently inactive in the develop branch. Could you please review the e2e results and let me know if any failing tests are related to my changes or if I can proceed with the merge? |
|
@ajayesivan thank you for the PR! Let me re-run e2e because there are bunch of failures caused by message reliability issues. I will keep you posted. |
82% of end-end tests have passedFailed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (40)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
@ajayesivan failed e2e are not PR related. Ready for merge. |
84% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Expected to fail tests (7)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Passed tests (41)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
|
jo-mut
pushed a commit
that referenced
this pull request
Dec 13, 2023
Samyoul
added
the
community-account-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17977 & #18081
Also added some style fixes along with changes.
Known issue
The account icon is currently 24x24, which does not align with the 32x32 size on Figma. This issue stems from the
settings_itemcomponent, where the size is hardcoded. Modifying that component will necessitate manual QA, so I will address it in a separate PR.Test Note
To test this, change the
community-accounts-selection-enabled?flag insrc/status_im2/config.cljstotrue.This feature is currently under a flag that is not enabled in the develop branch, so these changes do not require manual QA.