Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: skipped universal links test + some fixes #18128

Merged
merged 1 commit into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions test/appium/tests/activity_center/test_activity_center.py
Original file line number Diff line number Diff line change
Expand Up @@ -350,12 +350,6 @@ def test_activity_center_reply_read_unread_delete_filter_swipe(self):
if reply_element.is_element_displayed():
self.errors.append("Reply is still shown after removing from activity centre!")

self.home_1.just_fyi("Reset filter to show all AC notifications again")
self.home_1.reply_activity_tab_button.click()
self.home_1.mention_activity_tab_button.click()
self.home_1.all_activity_tab_button.click()
self.home_1.close_activity_centre.click()

self.errors.verify_no_errors()


Expand Down
4 changes: 2 additions & 2 deletions test/appium/tests/critical/chats/test_1_1_public_chats.py
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,9 @@ def test_1_1_chat_delete_via_long_press_relogin(self):
self.home_2.just_fyi("Deleting chat via delete button and check it will not reappear after relaunching app")
self.home_2.delete_chat_long_press(username=self.username_1)
if self.home_2.get_chat_from_home_view(self.username_1).is_element_displayed():
self.errors.append('Deleted %s chat is shown, but the chat has been deleted' % self.username_1)
self.errors.append("Deleted '%s' chat is shown, but the chat has been deleted" % self.username_1)
self.home_2.reopen_app()
if self.home_2.get_chat_from_home_view(self.username_1).is_element_displayed(15):
self.errors.append(
'Deleted chat %s is shown after re-login, but the chat has been deleted' % self.username_1)
"Deleted chat '%s' is shown after re-login, but the chat has been deleted" % self.username_1)
self.errors.verify_no_errors()
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def test_community_discovery(self):
self.errors.verify_no_errors()

@marks.testrail_id(702846)
@marks.xfail(reason="Issue #18075", run=False)
def test_community_navigate_to_channel_when_relaunch(self):
text_message = 'some_text'
if not self.channel.chat_message_input.is_element_displayed():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def test_links_deep_links(self):
self.errors.verify_no_errors()

@marks.testrail_id(704614)
@marks.skip # ToDo: the feature is not ready yet
def test_links_open_universal_links_from_other_apps(self):
app_package = self.driver.current_package
self.home.just_fyi("Opening a profile URL from google search bar when user is still logged in")
Expand Down
3 changes: 2 additions & 1 deletion test/appium/views/chat_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,8 @@ def image_in_message(self):
try:
self.driver.info("Trying to access image inside message with text '%s'" % self.message_text)
ChatElementByText(self.driver, self.message_text).wait_for_sent_state(60)
return Button(self.driver, xpath="%s//*[@content-desc='image-message']" % self.locator)
return Button(self.driver,
xpath="%s//android.widget.ImageView[@content-desc='image-message']" % self.locator)
except NoSuchElementException:
self.driver.fail("No image is found in message!")

Expand Down
Binary file modified test/appium/views/elements_templates/saucelabs_sauce_chat.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 4 additions & 3 deletions test/appium/views/home_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ def __init__(self, driver):

# Options on long tap
self.chats_menu_invite_friends_button = Button(self.driver, accessibility_id="chats-menu-invite-friends-button")
self.delete_chat_button = Button(self.driver, translation_id="close-chat")
self.close_chat_button = Button(self.driver, accessibility_id="close-chat")
self.confirm_closing_chat_button = Button(self.driver, accessibility_id="Confirm")
self.clear_history_button = Button(self.driver, accessibility_id="clear-history")
self.mute_chat_button = MuteButton(self.driver, accessibility_id="mute-chat")
self.mute_community_button = MuteButton(self.driver, accessibility_id="mute-community")
Expand Down Expand Up @@ -521,8 +522,8 @@ def open_status_test_dapp(self, url=test_dapp_url, allow_all=True):
def delete_chat_long_press(self, username):
self.driver.info("Deleting chat '%s' by long press" % username)
self.get_chat(username).long_press_element()
self.delete_chat_button.click()
self.delete_chat_button.click()
self.close_chat_button.click()
self.confirm_closing_chat_button.click()

def leave_chat_long_press(self, username):
self.driver.info("Leaving chat '%s' by long press" % username)
Expand Down