Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share screen design review #18148

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Share screen design review #18148

merged 4 commits into from
Jan 2, 2024

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Dec 11, 2023

Fixes #17569
Some of the issues were fixed before already, this PR fixes the rest.

Platforms

  • Android
  • iOS

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Dec 11, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (40)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 46ad9f9 #2 2023-12-11 13:50:49 ~6 min android 🤖apk 📲
✔️ 46ad9f9 #2 2023-12-11 13:50:59 ~6 min android-e2e 🤖apk 📲
✔️ 46ad9f9 #2 2023-12-11 13:54:59 ~10 min tests 📄log
✔️ 46ad9f9 #2 2023-12-11 13:57:33 ~13 min ios 📱ipa 📲
❌ 81e52d8 #3 2023-12-12 10:15:34 ~4 min tests 📄log
✔️ 81e52d8 #3 2023-12-12 10:17:23 ~6 min ios 📱ipa 📲
✔️ 81e52d8 #3 2023-12-12 10:17:39 ~6 min android 🤖apk 📲
✔️ 81e52d8 #3 2023-12-12 10:18:31 ~7 min android-e2e 🤖apk 📲
✔️ 570f9b7 #4 2023-12-13 09:22:58 ~4 min tests 📄log
✔️ 570f9b7 #4 2023-12-13 09:25:26 ~7 min android-e2e 🤖apk 📲
✔️ 570f9b7 #4 2023-12-13 09:26:19 ~8 min android 🤖apk 📲
✔️ 570f9b7 #4 2023-12-13 09:31:04 ~12 min ios 📱ipa 📲
✔️ 7701103 #5 2023-12-14 17:05:22 ~4 min tests 📄log
✔️ 7701103 #5 2023-12-14 17:08:23 ~7 min android-e2e 🤖apk 📲
✔️ 7701103 #5 2023-12-14 17:08:37 ~7 min android 🤖apk 📲
❌ 7701103 #5 2023-12-14 17:08:43 ~7 min ios 📄log
✔️ acae86e #6 2023-12-15 09:20:48 ~5 min tests 📄log
✔️ acae86e #6 2023-12-15 09:21:23 ~5 min ios 📱ipa 📲
✔️ acae86e #6 2023-12-15 09:23:28 ~8 min android-e2e 🤖apk 📲
✔️ acae86e #6 2023-12-15 09:23:32 ~8 min android 🤖apk 📲
✔️ 006f2cd #7 2023-12-15 17:56:05 ~4 min tests 📄log
✔️ 006f2cd #7 2023-12-15 17:58:54 ~7 min android-e2e 🤖apk 📲
✔️ 006f2cd #7 2023-12-15 17:59:18 ~7 min android 🤖apk 📲
✔️ 006f2cd #7 2023-12-15 18:04:43 ~13 min ios 📱ipa 📲
✔️ 8e9ce46 #8 2023-12-18 12:22:58 ~3 min tests 📄log
✔️ 8e9ce46 #8 2023-12-18 12:25:22 ~6 min ios 📱ipa 📲
✔️ 8e9ce46 #8 2023-12-18 12:26:33 ~7 min android-e2e 🤖apk 📲
✔️ 8e9ce46 #8 2023-12-18 12:26:40 ~7 min android 🤖apk 📲
✔️ da26ffc #9 2023-12-19 09:42:38 ~4 min tests 📄log
✔️ da26ffc #9 2023-12-19 09:45:54 ~8 min android-e2e 🤖apk 📲
✔️ da26ffc #9 2023-12-19 09:46:04 ~8 min android 🤖apk 📲
✔️ da26ffc #9 2023-12-19 09:49:57 ~12 min ios 📱ipa 📲
✔️ a2642b2 #10 2023-12-19 10:42:02 ~4 min tests 📄log
✔️ a2642b2 #10 2023-12-19 10:43:56 ~6 min ios 📱ipa 📲
✔️ a2642b2 #10 2023-12-19 10:45:39 ~7 min android-e2e 🤖apk 📲
✔️ a2642b2 #10 2023-12-19 10:45:45 ~7 min android 🤖apk 📲
✔️ 2c7c9ee #11 2023-12-19 12:10:28 ~4 min tests 📄log
✔️ 2c7c9ee #11 2023-12-19 12:13:47 ~8 min android 🤖apk 📲
✔️ 2c7c9ee #11 2023-12-19 12:13:51 ~8 min android-e2e 🤖apk 📲
✔️ 2c7c9ee #11 2023-12-19 12:19:28 ~13 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 92331c5 #12 2023-12-19 19:17:56 ~3 min tests 📄log
✔️ 92331c5 #12 2023-12-19 19:21:45 ~7 min android-e2e 🤖apk 📲
✔️ 92331c5 #12 2023-12-19 19:21:56 ~7 min android 🤖apk 📲
✔️ 92331c5 #12 2023-12-19 19:26:14 ~11 min ios 📱ipa 📲
✔️ f670ded #13 2024-01-02 09:20:03 ~5 min tests 📄log
✔️ f670ded #13 2024-01-02 09:21:41 ~6 min ios 📱ipa 📲
✔️ f670ded #13 2024-01-02 09:23:21 ~8 min android-e2e 🤖apk 📲
✔️ f670ded #13 2024-01-02 09:23:29 ~8 min android 🤖apk 📲

@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 6
Passed tests: 40

IDs of failed tests: 702745,702869 

IDs of expected to fail tests: 702732,702948,702894,703503,702731,702808

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find `MemberPhoto` by `xpath`: `//*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']`
    Device 2: Image differs from template to 6.57803404564951 percents 

    critical/chats/test_1_1_public_chats.py:312: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with text '¿Cómo estás tu año?' was not received



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: message to delete and undo 

    critical/chats/test_public_chat_browsing.py:113: in test_community_undo_delete_message
    self.channel.chat_element_by_text(message_to_delete).wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'message to delete and undo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

During handling of the above exception, another exception occurred:
critical/chats/test_public_chat_browsing.py:115: in test_community_undo_delete_message
    pytest.fail("Message was not restored by clicking 'Undo' button")
E   Failed: Message was not restored by clicking 'Undo' button



    Device sessions

    Expected to fail tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1078: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Receiver was not navigated to the cats channel
E    Sender was not navigated to the cats channel

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileSendMessageButton by accessibility id: Chat-item-button
    Device 1: Sending message 'piy' 

    critical/chats/test_public_chat_browsing.py:741: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat with unblocked user was not enabled after 1 minute

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (40)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Dec 15, 2023
    @VolodLytvynenko VolodLytvynenko force-pushed the share-screen-design-review branch from 7701103 to acae86e Compare December 15, 2023 09:15
    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 2
Failed tests: 0
Expected to fail tests: 0
Passed tests: 2

    Passed tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @alwx thank you for PR. No issues from my side
    Hey @Francesca-G could you take a look this PR, please?

    Francesca-G
    Francesca-G approved these changes Dec 15, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good ✨

    Only issue I spotted: the toast height doesn't match the design and the icon isn't aligned with text. I've encountered this issue recently in other PRs, please make sure it gets addressed, thank you :)

    Screenshot 2023-12-15 alle 16 37 41

    @alwx
    Copy link
    Contributor Author

    alwx commented Dec 18, 2023

    @Francesca-G I think changing toasts doesn't really fit the definition of what needs to be done in this particular issue. This is a separate issue for it: #17540

    @Francesca-G
    Copy link

    @Francesca-G I think changing toasts doesn't really fit the definition of what needs to be done in this particular issue. This is a separate issue for it: #17540

    Yes, I just wanted to make sure it wasn't missed. Thanks for linking the separate issue for it 🙏

    @alwx alwx force-pushed the share-screen-design-review branch from 92331c5 to f670ded Compare January 2, 2024 09:14
    @alwx alwx merged commit 4a9ca80 into develop Jan 2, 2024
    6 checks passed
    @alwx alwx deleted the share-screen-design-review branch January 2, 2024 09:23
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @siddarthkay siddarthkay siddarthkay approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    Assignees

    @alwx alwx

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Design Review: Share Screen
    6 participants
    @alwx @status-im-auto @VolodLytvynenko @Francesca-G @smohamedjavid @siddarthkay