Share wallet address [17865] #18159
Share wallet address [17865] #18159
Conversation
Jenkins BuildsClick to see older builds (7)
|
There was a problem hiding this comment.
Please make sure to update the docstring and component API to properly reflect the new design.
Also, please update the preview screen and test if needed.
In PR's description, the screenshot of the new design doesn't show the configuration icon, so make sure it's being properly rendered.
| (def ^:private dashed-line-width 2) | ||
| (def ^:private dashed-line-space 4) |
There was a problem hiding this comment.
If we are not going to use these styles anymore, we should remove them 👍
| :style | ||
| (style/header-title component-width) |
There was a problem hiding this comment.
They should be in the same line (46)
| $ yarn shadow-cljs run re-frisk-remote.core/start | ||
| yarn shadow-cljs run re-frisk-remote.core/start | ||
| ``` | ||
|
|
||
| or you can also use make: | ||
|
|
||
| ```bash | ||
| $ make run-re-frisk | ||
| make run-re-frisk |
There was a problem hiding this comment.
Maybe unrelated changes?
There was a problem hiding this comment.
i know that i should create a separate pr for these two lines, but since can we smuggle them here? :)
There was a problem hiding this comment.
do we have an isue for it or something?
tumanov-alex
force-pushed
the
17865-share-wallet-address
branch
2 times, most recently
from
d6c0623 to
d5c0eec
Compare
tumanov-alex
force-pushed
the
17865-share-wallet-address
branch
from
d5c0eec to
2f2ad8a
Compare
|
Hey Alex, by loking at the screenshots seems the grandient is also missing 😅 |
fixes #17865
Share wallet address design update (UI only)
While I'm working on adding share-qr-code to the wallet share screen and re-using swipeable status component, I've decided to share the UI part asap
Steps to test
share-qr-codeBefore and after screenshots comparison
Before:
After:
| Figma (if available)
status: ready