Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/clean metro logs remove old wallet UI #18165

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Feature/clean metro logs remove old wallet UI #18165

merged 5 commits into from
Dec 13, 2023

Conversation

flexsurfer
Copy link
Member

clean metro logs remove old wallet UI

@flexsurfer flexsurfer self-assigned this Dec 13, 2023
J-Son89
J-Son89 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@status-im-auto
Copy link
Member

status-im-auto commented Dec 13, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ ed6b60a #1 2023-12-13 11:52:17 ~4 min tests 📄log
✔️ ed6b60a #1 2023-12-13 11:54:16 ~6 min ios 📱ipa 📲
✔️ ed6b60a #1 2023-12-13 11:55:10 ~7 min android 🤖apk 📲
✔️ ed6b60a #1 2023-12-13 11:55:20 ~7 min android-e2e 🤖apk 📲
✔️ 823ede8 #2 2023-12-13 12:34:15 ~4 min tests 📄log
✔️ 823ede8 #2 2023-12-13 12:36:16 ~6 min ios 📱ipa 📲
✔️ 823ede8 #2 2023-12-13 12:37:34 ~7 min android-e2e 🤖apk 📲
✔️ 823ede8 #2 2023-12-13 12:38:03 ~7 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 630a108 #3 2023-12-13 12:43:05 ~4 min tests 📄log
✔️ 630a108 #3 2023-12-13 12:45:53 ~6 min android-e2e 🤖apk 📲
✔️ 630a108 #3 2023-12-13 12:46:05 ~7 min android 🤖apk 📲
✔️ 630a108 #3 2023-12-13 12:51:24 ~12 min ios 📱ipa 📲
✔️ 9dc78d7 #5 2023-12-13 12:56:31 ~4 min tests 📄log
✔️ 9dc78d7 #5 2023-12-13 12:58:40 ~6 min ios 📱ipa 📲
✔️ 9dc78d7 #5 2023-12-13 12:59:55 ~7 min android-e2e 🤖apk 📲
✔️ 9dc78d7 #5 2023-12-13 12:59:56 ~7 min android 🤖apk 📲

@flexsurfer flexsurfer force-pushed the feature/clean-metro-logs-remove-old-wallet-ui branch from ed6b60a to 823ede8 Compare December 13, 2023 12:29
smohamedjavid
smohamedjavid approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @flexsurfer 🚀

@status-im-auto
Copy link
Member

81% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Expected to fail tests: 6
Passed tests: 39

IDs of failed tests: 702809,703629,702775 

IDs of expected to fail tests: 702732,702948,702894,703503,702731,702808

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:984: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in 1-1 chat for the recipient (device 2)



    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1145: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    None; 
 RemoteDisconnected



    Device sessions

    Expected to fail tests (6)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileSendMessageButton by accessibility id: Chat-item-button
    Device 1: Sending message 'piy' 

    critical/chats/test_public_chat_browsing.py:741: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat with unblocked user was not enabled after 1 minute

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1078: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Receiver was not navigated to the cats channel
E    Sender was not navigated to the cats channel

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    Device sessions

    Passed tests (39)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_unread_messages_badge, id: 702841
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_several_images_send_reply, id: 703194
    Device sessions

    5. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    6. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    7. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_mute_community_and_channel, id: 703382
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    @flexsurfer flexsurfer merged commit 0eb424b into develop Dec 13, 2023
    6 checks passed
    @flexsurfer flexsurfer deleted the feature/clean-metro-logs-remove-old-wallet-ui branch December 13, 2023 15:11
    @Parveshdhull Parveshdhull mentioned this pull request Feb 19, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    Assignees

    @flexsurfer flexsurfer

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @flexsurfer @status-im-auto @smohamedjavid @J-Son89