move status-im from utils #18249
Merged
move status-im from utils #18249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexsurfer
commented
Dec 20, 2023
| :clock clock | ||
| :theme theme | ||
| :override-ring? (when ens-name false)})] | ||
| :clock |
There was a problem hiding this comment.
have no idea why it was moved next line
Jenkins BuildsClick to see older builds (4)
|
siddarthkay
reviewed
Dec 20, 2023
siddarthkay
approved these changes
Dec 20, 2023
Parveshdhull
approved these changes
Dec 20, 2023
90% of end-end tests have passedExpected to fail tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
|
|
@status-im/mobile-qa could someone please take a quick look when have some time, thank you |
|
Hey, @flexsurfer. Thank you for your work. I will check this PR. Any known impacted areas? |
|
thanks @VolodLytvynenko media server, so images for contacts etc |
ISSUE 1: The avatar image is not shown after setupSteps to Reproduce:
Actual Result:The avatar image does not appear on any of the pages where it is expected to be shown.
Expected Result:the avatar image to be displayed correctly on all pages where the avatar is intended to appear. Devices:
Logs: |
|
thanks @VolodLytvynenko fixed |
|
@flexsurfer issue 1 is fixed. One more issue is found ISSUE 2: User avatar displays as [x] when Image is not setSteps to Reproduce:
Actual result:Instead of displaying an avatar placeholder, the [x] symbol is shown in place of the avatar Expected result:Default avatar placeholder is shown Devices:
|
69% of end-end tests have passedFailed tests (11)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Passed tests (33)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
yqrashawn
approved these changes
Dec 21, 2023
flexsurfer
force-pushed
the
feature/remove-status-im-from-utils
branch
from
303af9d to
a56e3e8
Compare
|
sorry @VolodLytvynenko should be fixed now |
79% of end-end tests have passedNot executed tests (1)Failed tests (5)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (38)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
|
Thanks for the fixes @flexsurfer, PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move status-im from utils