Quo - truncation for component wallet/account card fix truncation

[Pau1fitz]

Quo - If the name is too long on a wallet account text should be truncated using an ellipsis.

Fixes #18044

Figma example

Before:

After:

Testing notes:
Create a new wallet account with a really long name
Go to wallet home page
Observe wallet card uses ellipsis as in the designs.

Can also be tested in the Quo preview screen for wallet -> account card component

Can be tested on release builds here:
#18256 (comment)

[ghost]

Hey @Pau1fitz, and thank you so much for making your first pull request in status-mobile! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

[siddarthkay]

looks good

[smohamedjavid]

Thank you for the fix! @Pau1fitz 🚀

[J-Son89]

@status-im/mobile-qa - this can be tested here: #18259

[Pau1fitz]

@smohamedjavid @OmarBasem @siddarthkay @J-Son89

is the below a known issue? When you type the keyboard doesn't expand.

Screen.Recording.2023-12-20.at.17.04.55.mov

[smohamedjavid]

is the below a known issue? When you type the keyboard doesn't expand.

It's the iOS simulator's behaviour when you type using your system (hard) keyboard. The device's (soft) keyboard can be toggled by using cmd (⌘) + K.

[pavloburykh]

@Pau1fitz thanx for the PR.

In case of watch only account we need to take into consideration the size of the "eye icon". Otherwise in case of long name it is displaced too close to the wallet card border (see screenshot below). @J-Son89 WDYT? I have not found an example of long name watch only account in Figma.

Below screenshot is taken on iPhone X, IOS 16.4

[J-Son89]

@Pau1fitz thanx for the PR.

In case of watch only account we need to take into consideration the size of the "eye icon". Otherwise in case of long name it is displaced too close to the wallet card border (see screenshot below). @J-Son89 WDYT? I have not found an example of long name watch only account in Figma.

Below screenshot is taken on iPhone X, IOS 16.4

good spot @Pau1fitz, yeah should be easy enough to add this. Seems just like some padding or margin should sort it 👍

[Pau1fitz]

after pulling the latest code and running make run-metro I am seeing the following error. Has anyone seen this before?

 ERROR  TypeError: native_module.core.status.call(null).fleets is not a function. (In 'native_module.core.status.call(null).fleets()', 'native_module.core.status.call(null).fleets' is undefined)

[J-Son89]

ah yes, there was a recent breaking change made to Status-Go where fleets changed. You will have to re run make run-ios to rebuild the app

[Pau1fitz]

@pavloburykh ready for re-testing. See screenshots below

[pavloburykh]

@J-Son89 could you please update correspondent #18259 so I can test changes? Thank you.

[pavloburykh]

@J-Son89 nevermind. Sorry, I have forgotten that you are off.

[J-Son89]

No problem @pavloburykh, I had one or two questions about the update I sent to @Pau1fitz. Once I get an answer I'll update the other pr with changes. We can wait with testing until then. Thanks!

[pavloburykh]

@Pau1fitz thank you for the fix. Tested in #18256. Ready for merge.

[pavloburykh]

No problem @pavloburykh, I had one or two questions about the update I sent to @Pau1fitz. Once I get an answer I'll update the other pr with changes. We can wait with testing until then. Thanks!

Oh, okay. Missed this comment @J-Son89 and moved PR to merged already. Ping me up if it will require re-test.

[J-Son89]

Ah no problem, good from my side now too so I'll merge it 👌