Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix android-e2e nightly builds #18261

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

yakimant
Copy link
Member

@status-im-auto
Copy link
Member

status-im-auto commented Dec 20, 2023

Jenkins Builds

Click to see older builds (15)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 561bcdc #1 2023-12-20 16:26:13 ~5 min tests 📄log
✔️ 561bcdc #1 2023-12-20 16:26:58 ~6 min ios 📱ipa 📲
✔️ 561bcdc #1 2023-12-20 16:27:45 ~6 min android 🤖apk 📲
✔️ 09d2964 #2 2023-12-20 16:34:46 ~4 min tests 📄log
✔️ 09d2964 #2 2023-12-20 16:37:00 ~6 min android-e2e 🤖apk 📲
✔️ 09d2964 #2 2023-12-20 16:38:24 ~8 min android 🤖apk 📲
✔️ 09d2964 #2 2023-12-20 16:41:48 ~11 min ios 📱ipa 📲
✔️ f5bb466 #3 2023-12-20 16:54:37 ~4 min tests 📄log
✔️ f5bb466 #3 2023-12-20 16:55:30 ~5 min ios 📱ipa 📲
✔️ f5bb466 #3 2023-12-20 16:57:19 ~7 min android 🤖apk 📲
✔️ f5bb466 #3 2023-12-20 16:57:36 ~7 min android-e2e 🤖apk 📲
✔️ 98ded83 #4 2023-12-21 11:20:59 ~4 min tests 📄log
✔️ 98ded83 #4 2023-12-21 11:22:47 ~6 min ios 📱ipa 📲
✔️ 98ded83 #4 2023-12-21 11:24:36 ~8 min android-e2e 🤖apk 📲
✔️ 98ded83 #4 2023-12-21 11:24:39 ~8 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f0e84d5 #5 2023-12-21 11:42:28 ~4 min tests 📄log
✔️ f0e84d5 #5 2023-12-21 11:44:34 ~6 min android 🤖apk 📲
✔️ f0e84d5 #5 2023-12-21 11:45:33 ~7 min android-e2e 🤖apk 📲
f0e84d5 #5 2023-12-21 11:49:43 ~11 min ios 📄log
✔️ f0e84d5 #6 2023-12-21 12:02:10 ~12 min ios 📱ipa 📲
✔️ ad50d29 #6 2023-12-21 12:38:51 ~4 min tests 📄log
✔️ ad50d29 #6 2023-12-21 12:40:40 ~6 min android-e2e 🤖apk 📲
✔️ ad50d29 #6 2023-12-21 12:41:59 ~8 min android 🤖apk 📲
✔️ ad50d29 #7 2023-12-21 12:48:31 ~14 min ios 📱ipa 📲

@yakimant
Copy link
Member Author

yakimant commented Dec 21, 2023

There are multiple places dealing with .env files and this is a bit confusing:

  1. As a Prep Stage:
    https://github.com/status-im/status-jenkins-lib/blob/92211a95e62e67dba0861a438de2b1acfecd2cfb/vars/utils.groovy#L228-L240

  2. As a part of Android build:

    cp -bf ./${envFileName} ./.env

They also have slightly different logic on choosing the right .env file.

It's better to review the logic later.

@yakimant
Copy link
Member Author

yakimant commented Dec 21, 2023

As for now - issue was caused by switching e2e build from x86 to x86_64, so this stopped working:

if androidAbiInclude == "x86" then ".env.e2e"

I will quick fix it in this PR.

@yakimant yakimant force-pushed the fix_nightly_android_e2e branch from f5bb466 to 98ded83 Compare December 21, 2023 11:15
@yakimant yakimant marked this pull request as ready for review December 21, 2023 11:16
@yakimant yakimant requested a review from jakubgs as a code owner December 21, 2023 11:16
@yakimant yakimant requested a review from siddarthkay December 21, 2023 11:16
@yakimant yakimant force-pushed the fix_nightly_android_e2e branch from 98ded83 to f0e84d5 Compare December 21, 2023 11:37
@yakimant yakimant force-pushed the fix_nightly_android_e2e branch from f0e84d5 to ad50d29 Compare December 21, 2023 12:33
@yakimant yakimant merged commit 2d22ed8 into develop Dec 21, 2023
6 checks passed
@yakimant yakimant deleted the fix_nightly_android_e2e branch December 21, 2023 13:36
@jakubgs
Copy link
Member

jakubgs commented Jan 2, 2024

Yes, .env.* files are confusing and would be nice to review all of them. I'm sure we could simplify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants