Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#18182] feat: implement edit profile and change name #18270

Merged
merged 16 commits into from
Jan 8, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Dec 21, 2023

fixes #18182

Implement edit profile UI and edit profile name UI and functionality

Effected Area

  • Create profile (just profile name validation)

Screenshots

Video

Edit name and sync between devices

Screen.Recording.2023-12-27.at.23.04.45.mov

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Dec 21, 2023

Jenkins Builds

Click to see older builds (61)
Commit #️⃣ Finished (UTC) Duration Platform Result
ed7f81c #2 2023-12-21 14:26:58 ~2 min tests 📄log
✔️ ed7f81c #2 2023-12-21 14:32:01 ~7 min android-e2e 🤖apk 📲
✔️ ed7f81c #2 2023-12-21 14:32:09 ~7 min android 🤖apk 📲
✔️ ed7f81c #2 2023-12-21 14:37:13 ~13 min ios 📱ipa 📲
3f05a31 #3 2023-12-25 21:04:39 ~2 min tests 📄log
✔️ 3f05a31 #3 2023-12-25 21:08:08 ~5 min ios 📱ipa 📲
✔️ 3f05a31 #3 2023-12-25 21:09:44 ~7 min android-e2e 🤖apk 📲
✔️ 3f05a31 #3 2023-12-25 21:09:50 ~7 min android 🤖apk 📲
1b11790 #4 2023-12-27 04:56:14 ~2 min tests 📄log
✔️ 1b11790 #4 2023-12-27 05:00:30 ~6 min ios 📱ipa 📲
✔️ 1b11790 #4 2023-12-27 05:00:58 ~6 min android 🤖apk 📲
✔️ 1b11790 #4 2023-12-27 05:01:16 ~7 min android-e2e 🤖apk 📲
✔️ a01e138 #5 2023-12-27 17:50:09 ~5 min tests 📄log
✔️ a01e138 #5 2023-12-27 17:51:01 ~5 min ios 📱ipa 📲
✔️ a01e138 #5 2023-12-27 17:53:37 ~8 min android-e2e 🤖apk 📲
✔️ a01e138 #5 2023-12-27 17:53:43 ~8 min android 🤖apk 📲
✔️ f48fa34 #6 2023-12-27 18:06:18 ~4 min tests 📄log
✔️ f48fa34 #6 2023-12-27 18:07:21 ~6 min ios 📱ipa 📲
✔️ f48fa34 #6 2023-12-27 18:09:52 ~8 min android-e2e 🤖apk 📲
✔️ f48fa34 #6 2023-12-27 18:09:57 ~8 min android 🤖apk 📲
✔️ 8347397 #7 2023-12-27 21:08:27 ~4 min tests 📄log
✔️ 8347397 #7 2023-12-27 21:11:53 ~8 min android-e2e 🤖apk 📲
✔️ 8347397 #7 2023-12-27 21:12:00 ~8 min android 🤖apk 📲
✔️ 8347397 #7 2023-12-27 21:15:34 ~12 min ios 📱ipa 📲
cc661a5 #8 2023-12-27 22:12:26 ~2 min tests 📄log
✔️ cc661a5 #8 2023-12-27 22:17:39 ~7 min android-e2e 🤖apk 📲
✔️ cc661a5 #8 2023-12-27 22:17:39 ~7 min android 🤖apk 📲
✔️ cc661a5 #8 2023-12-27 22:22:59 ~13 min ios 📱ipa 📲
✔️ b96e594 #9 2023-12-28 10:14:34 ~4 min tests 📄log
✔️ b96e594 #9 2023-12-28 10:17:14 ~7 min ios 📱ipa 📲
✔️ b96e594 #9 2023-12-28 10:18:02 ~8 min android-e2e 🤖apk 📲
✔️ b96e594 #9 2023-12-28 10:18:10 ~8 min android 🤖apk 📲
✔️ ca17eff #10 2023-12-28 15:07:44 ~5 min ios 📱ipa 📲
ca17eff #10 2023-12-28 15:12:42 ~10 min tests 📄log
ca17eff #10 2023-12-28 15:12:49 ~10 min android-e2e 📄log
ca17eff #10 2023-12-28 15:12:49 ~10 min android 📄log
✔️ ca17eff #11 2023-12-28 15:33:55 ~6 min android 🤖apk 📲
✔️ 2d6a9e9 #11 2023-12-28 15:40:18 ~4 min tests 📄log
✔️ 2d6a9e9 #11 2023-12-28 15:43:42 ~8 min android-e2e 🤖apk 📲
✔️ 2d6a9e9 #12 2023-12-28 15:43:54 ~8 min android 🤖apk 📲
✔️ 2d6a9e9 #11 2023-12-28 15:48:59 ~13 min ios 📱ipa 📲
✔️ 62a4b5f #13 2023-12-29 10:39:34 ~4 min tests 📄log
✔️ 62a4b5f #13 2023-12-29 10:42:17 ~6 min android-e2e 🤖apk 📲
✔️ 62a4b5f #14 2023-12-29 10:42:24 ~6 min android 🤖apk 📲
✔️ 62a4b5f #13 2023-12-29 10:49:49 ~14 min ios 📱ipa 📲
✔️ 329bbe9 #14 2024-01-02 11:36:22 ~5 min tests 📄log
✔️ 329bbe9 #14 2024-01-02 11:37:12 ~5 min ios 📱ipa 📲
✔️ 329bbe9 #14 2024-01-02 11:39:45 ~8 min android-e2e 🤖apk 📲
✔️ 329bbe9 #15 2024-01-02 11:39:48 ~8 min android 🤖apk 📲
✔️ fe967ae #15 2024-01-02 18:48:41 ~5 min tests 📄log
✔️ fe967ae #15 2024-01-02 18:49:56 ~6 min ios 📱ipa 📲
✔️ fe967ae #15 2024-01-02 18:51:59 ~8 min android-e2e 🤖apk 📲
✔️ fe967ae #16 2024-01-02 18:52:06 ~8 min android 🤖apk 📲
✔️ a070b2b #16 2024-01-02 21:01:04 ~5 min tests 📄log
✔️ a070b2b #16 2024-01-02 21:01:44 ~5 min ios 📱ipa 📲
✔️ a070b2b #17 2024-01-02 21:04:24 ~8 min android 🤖apk 📲
✔️ a070b2b #16 2024-01-02 21:04:26 ~8 min android-e2e 🤖apk 📲
✔️ f9e655b #17 2024-01-04 11:49:13 ~4 min tests 📄log
✔️ f9e655b #17 2024-01-04 11:51:19 ~6 min ios 📱ipa 📲
✔️ f9e655b #17 2024-01-04 11:52:29 ~7 min android-e2e 🤖apk 📲
✔️ f9e655b #18 2024-01-04 11:52:32 ~7 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ec6a8ac #18 2024-01-04 17:50:31 ~5 min tests 📄log
✔️ ec6a8ac #18 2024-01-04 17:52:42 ~7 min ios 📱ipa 📲
✔️ ec6a8ac #18 2024-01-04 17:54:08 ~8 min android-e2e 🤖apk 📲
✔️ ec6a8ac #19 2024-01-04 17:54:11 ~8 min android 🤖apk 📲
✔️ d7bb93f #19 2024-01-08 15:11:22 ~7 min android-e2e 🤖apk 📲
✔️ d7bb93f #19 2024-01-08 15:11:56 ~7 min ios 📱ipa 📲
✔️ d7bb93f #19 2024-01-08 15:12:33 ~8 min tests 📄log
✔️ d7bb93f #20 2024-01-08 15:25:16 ~20 min android 🤖apk 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/edit-profile branch 4 times, most recently from a01e138 to f48fa34 Compare December 27, 2023 18:01
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review December 27, 2023 21:03
@mohsen-ghafouri
Copy link
Contributor Author

Please any suggestions regarding folder structure/file name are welcome

@OmarBasem
Copy link
Contributor

I think the navigation animation where you open the Edit Profile screen should be a right-to-left animation rather than a modal animation

@mohsen-ghafouri
Copy link
Contributor Author

@OmarBasem the background is blur and should show edit profile screen behind edit name screen. is it possible to achieve this with right-to-left animation? if yes could you give me an example ?

@OmarBasem
Copy link
Contributor

OmarBasem commented Dec 28, 2023

@OmarBasem the background is blur and should show edit profile screen behind edit name screen. is it possible to achieve this with right-to-left animation? if yes could you give me an example ?

I mean for the screen when you press on edit-profile.

The edit-name screen I think it will have to be a modal to be blurry

Edit: if the edit-profile screen has to be blurry too, then fine

@mohsen-ghafouri
Copy link
Contributor Author

Thanks @OmarBasem for reviewing this, yes these 3 screens have blurry background, settings -> edit profile -> edit name.

src/status_im/contexts/profile/edit/header/view.cljs Outdated Show resolved Hide resolved
src/status_im/events.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/profile/edit/name/view.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/profile/edit/name/utils.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/profile/edit/name/utils.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/profile/edit/name/events.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/profile/edit/name/view.cljs Outdated Show resolved Hide resolved
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 4
Passed tests: 42
IDs of failed tests: 703133,703629 
IDs of expected to fail tests: 702732,703503,702731,702808 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community'

    critical/chats/test_public_chat_browsing.py:1136: in test_community_join_when_node_owner_offline
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Joined status is not displayed
    E    open community is not listed inside Joined communities tab
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     zQ3...dWXh5 was not restored as a contact from waku backup!
    E    zQ3...Vacac was not restored as a contact from waku backup!
    E    admin_open was not restored from waku-backup!!
    E    member_open was not restored from waku-backup!!
    E    admin_closed was not restored from waku-backup!!
    E    member_closed was not restored from waku-backup!!
    



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Messages PN was not fetched from offline 
    

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (42)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Thanks for your feedbacks, I will resolve this issue before merging the PR. @qoqobolo @Francesca-G

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Resolved -> disable button when user is typing

    Simulator.Screen.Recording.-.iPhone.13.-.2024-01-08.at.18.05.03.mp4

    @mohsen-ghafouri mohsen-ghafouri merged commit b4d27d2 into develop Jan 8, 2024
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the feat/edit-profile branch January 8, 2024 15:27
    @mohsen-ghafouri mohsen-ghafouri changed the title feat: implement edit profile and change name [#18182] feat: implement edit profile and change name Jan 10, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Edit profile - Change name
    9 participants