-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#18182] feat: implement edit profile and change name #18270
Conversation
86a76c1
to
ed7f81c
Compare
Jenkins BuildsClick to see older builds (61)
|
a01e138
to
f48fa34
Compare
8347397
to
cc661a5
Compare
Please any suggestions regarding folder structure/file name are welcome |
cc661a5
to
b96e594
Compare
I think the navigation animation where you open the Edit Profile screen should be a right-to-left animation rather than a modal animation |
@OmarBasem the background is blur and should show edit profile screen behind edit name screen. is it possible to achieve this with right-to-left animation? if yes could you give me an example ? |
I mean for the screen when you press on edit-profile. The edit-name screen I think it will have to be a modal to be blurry Edit: if the edit-profile screen has to be blurry too, then fine |
b96e594
to
ca17eff
Compare
Thanks @OmarBasem for reviewing this, yes these 3 screens have blurry background, settings -> edit profile -> edit name. |
ca17eff
to
2d6a9e9
Compare
88% of end-end tests have passed
Failed tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
Thanks for your feedbacks, I will resolve this issue before merging the PR. @qoqobolo @Francesca-G |
ec6a8ac
to
d7bb93f
Compare
Resolved -> disable button when user is typing Simulator.Screen.Recording.-.iPhone.13.-.2024-01-08.at.18.05.03.mp4 |
fixes #18182
Implement edit profile UI and edit profile name UI and functionality
Effected Area
Screenshots
Video
Edit name and sync between devices
Screen.Recording.2023-12-27.at.23.04.45.mov
status: ready