Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xcbeautify to iOS shell and to make run-ios #18273

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add xcbeautify to iOS shell and to make run-ios #18273

merged 1 commit into from
Dec 22, 2023

Conversation

siddarthkay
Copy link
Contributor

I can't remember the number of times I have had to ask developers to run make run-ios | xcbeautify when debugging iOS build failures and they do not have xcbeautify installed on their environment.

xcbeautify helps make xcodebuild output more readable and to identify problems quickly.

This PR adds xcbeautify to iOS shell and to make run-ios so that we get readable output by default.

status: ready

@siddarthkay siddarthkay self-assigned this Dec 21, 2023
@siddarthkay siddarthkay requested a review from jakubgs as a code owner December 21, 2023 18:59
@siddarthkay siddarthkay force-pushed the add-xcbeautify-to-shell branch from 4b298f5 to dd768f4 Compare December 21, 2023 19:00
@status-im-auto
Copy link
Member

status-im-auto commented Dec 21, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dd768f4 #2 2023-12-21 19:05:57 ~4 min tests 📄log
✔️ dd768f4 #2 2023-12-21 19:08:45 ~7 min android 🤖apk 📲
✔️ dd768f4 #2 2023-12-21 19:08:54 ~7 min android-e2e 🤖apk 📲
✔️ dd768f4 #2 2023-12-21 19:14:09 ~12 min ios 📱ipa 📲
✔️ e7328e3 #3 2023-12-22 01:14:45 ~4 min tests 📄log
✔️ e7328e3 #3 2023-12-22 01:16:45 ~6 min android-e2e 🤖apk 📲
✔️ e7328e3 #3 2023-12-22 01:16:48 ~6 min ios 📱ipa 📲
✔️ e7328e3 #3 2023-12-22 01:17:53 ~7 min android 🤖apk 📲
✔️ 7fc3f8e #4 2023-12-22 12:26:04 ~5 min tests 📄log
✔️ 7fc3f8e #4 2023-12-22 12:27:40 ~6 min ios 📱ipa 📲
✔️ 7fc3f8e #4 2023-12-22 12:29:43 ~8 min android-e2e 🤖apk 📲
✔️ 7fc3f8e #4 2023-12-22 12:29:48 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ab9c88b #6 2023-12-22 13:23:45 ~4 min tests 📄log
✔️ ab9c88b #6 2023-12-22 13:25:31 ~5 min ios 📱ipa 📲
✔️ ce7082c #8 2023-12-22 13:31:35 ~4 min tests 📄log
✔️ ce7082c #8 2023-12-22 13:33:13 ~6 min ios 📱ipa 📲
✔️ ce7082c #8 2023-12-22 13:33:20 ~6 min android-e2e 🤖apk 📲
✔️ ce7082c #8 2023-12-22 13:34:33 ~7 min android 🤖apk 📲

@status-im-auto
Copy link
Member

58% of end-end tests have passed

Total executed tests: 48
Failed tests: 16
Expected to fail tests: 4
Passed tests: 28
Not executed tests: 1

IDs of not executed tests: 704614 

IDs of failed tests: 703194,702859,702777,703133,702851,702840,703086,702894,702850,704615,703202,702839,702838,702844,702843,702841 

IDs of expected to fail tests: 702732,703503,702731,702808

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (16)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 
    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    6. test_community_edit_delete_message_when_offline, id: 704615 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    7. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    8. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find Button by accessibility id: show-qr-button
    Device 2: Tap on found: Button 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    10. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    11. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/chats/test_public_chat_browsing.py:288: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key_via_share_profile_tab()
../views/home_view.py:573: in get_public_key_via_share_profile_tab
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...pJN5P was not restored as a contact from waku backup!
E    zQ3...UxXqE was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777 

    Test setup failed: activity_center/test_activity_center.py:27: in prepare_devices
    self.profile_link_2 = self.home_2.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 

    Test setup failed: activity_center/test_activity_center.py:27: in prepare_devices
    self.profile_link_2 = self.home_2.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    3. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: show-qr-button
    Device 2: Tap on found: Button 

    Test setup failed: activity_center/test_activity_center.py:27: in prepare_devices
    self.profile_link_2 = self.home_2.get_link_to_profile()
../views/home_view.py:567: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`(//*[@content-desc='link-to-profile']/preceding-sibling::*[1]/android.widget.TextView)[1]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find Button by accessibility id: authors-for-reaction-5
    Device 1: Tap on found: Button 

    critical/chats/test_group_chat.py:211: in test_group_chat_reactions
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect reactions count for user admin after changing the reactions



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (28)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @siddarthkay siddarthkay force-pushed the add-xcbeautify-to-shell branch from dd768f4 to e7328e3 Compare December 22, 2023 01:09
    @siddarthkay siddarthkay force-pushed the add-xcbeautify-to-shell branch 3 times, most recently from ab9c88b to e408b6d Compare December 22, 2023 13:25
    @siddarthkay
    feat: add xcbeautify to iOS shell
    ce7082c 
    I can't remember the number of times I have had to ask developers to run `make run-ios | xcbeautify` when debugging iOS build failures and they do not have `xcbeautify` installed on their environment.

`xcbeautify` helps make `xcodebuild` output more readable and to identify problems quickly.

This commit adds `xcbeautify` to iOS shell and to  `make run-ios` so that we get readable output by default.
    @siddarthkay siddarthkay force-pushed the add-xcbeautify-to-shell branch from e408b6d to ce7082c Compare December 22, 2023 13:26
    @siddarthkay siddarthkay merged commit 10b9784 into develop Dec 22, 2023
    6 checks passed
    @siddarthkay siddarthkay deleted the add-xcbeautify-to-shell branch December 22, 2023 14:16
    @siddarthkay
    Copy link
    Contributor Author

    @status-im/mobile-qa : skipped QA because this change only impacts local iOS builds

    jakubgs
    jakubgs reviewed Jan 2, 2024
    View reviewed changes
    Copy link
    Member

    @jakubgs jakubgs left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Would be good to submit xcbeautify package to nixpkgs.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jakubgs jakubgs jakubgs left review comments

    @OmarBasem OmarBasem OmarBasem approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @yakimant yakimant yakimant approved these changes

    @FFFra FFFra Awaiting requested review from FFFra

    @ajayesivan ajayesivan Awaiting requested review from ajayesivan

    Assignees

    @siddarthkay siddarthkay

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    8 participants
    @siddarthkay @status-im-auto @yakimant @jakubgs @flexsurfer @smohamedjavid @J-Son89 @OmarBasem