Add :wallet/accounts-with-customization-color subscription
#18302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
ilmotta
reviewed
Dec 26, 2023
| :<- [:wallet/accounts] | ||
| (fn [accounts] | ||
| (mapv (fn [{:keys [color] :as account}] | ||
| (assoc account :customization-color color)) |
There was a problem hiding this comment.
This subscription just duplicates the value of :customization-color in each account map. I don't see much value in this processing taking place as a subscription. Why can't the view use the :color key directly?
There was a problem hiding this comment.
DS components are designed to accept the :customization-color prop, if we are not doing this transformation here, we will have to map it before passing the data to the components each time. For example, here when using the quo/category component.
ilmotta
approved these changes
Dec 26, 2023
| :wallet/accounts-with-customization-color | ||
| :<- [:wallet/accounts] | ||
| (fn [accounts] | ||
| (mapv (fn [{:keys [color] :as account}] |
There was a problem hiding this comment.
Using lazy sequences can be beneficial if other computations will (could be in the future) performed on the result of this subscription. mapv will eagerly process everything, which is likely fine because accounts is a small data set.
Things can get confusing and inefficient if we mix them, so it's more common in Clojure that devs use the lazy ones and only use eager alternatives if really needed.
ajayesivan
force-pushed
the
18198-wallet-account-subscription
branch
from
3c013c9 to
6b35cc2
Compare
67% of end-end tests have passedFailed tests (9)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (32)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
ajayesivan
force-pushed
the
18198-wallet-account-subscription
branch
from
6b35cc2 to
2f3e4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18198
status: ready