Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error is shown when asset is selected on select assets screen #18326

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix: error is shown when asset is selected on select assets screen #18326

merged 1 commit into from
Jan 4, 2024

Conversation

briansztamfater
Copy link
Member

@briansztamfater briansztamfater commented Dec 29, 2023 •
edited
Loading

fixes #18228

Summary

Based on the logs provided I can guess this line

status-mobile/src/status_im/contexts/wallet/send/input_amount/view.cljs

Line 19 in 2e684b3

(str amount " " (string/upper-case (name currency))))
is causing a crash if for some reason the input amount screen is loaded before de DB is updated. I am adding a fallback value to token-symbol binding to prevent the crash.

Relevant logs:

12-19 10:14:58.410 10249 10383 D ReactNativeJS: 2023-12-19T08:14:58.409Z DEBUG [utils.re-frame:22] - Handling re-frame event:  :wallet/send-select-token
12-19 10:14:58.425 10249 10383 I ReactNativeJS: Running "wallet-send-input-amount
12-19 10:14:58.435 10249 10383 E ReactNativeJS: Error: Doesn't support name: 
12-19 10:14:58.435 10249 10383 E ReactNativeJS: 
12-19 10:14:58.435 10249 10383 E ReactNativeJS: This error is located at:
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in kLd
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in reagent86
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in Qp
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in b
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in RCTView
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in Unknown
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in rH
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in reagent85
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in RNGestureHandlerRootView
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in GestureHandlerRootView
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in gestureHandlerRootHOC(reagent85)
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in WrappedComponent
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in RCTView
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in Unknown
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in RCTView
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in Unknown
12-19 10:14:58.435 10249 10383 E ReactNativeJS:     in AppContainer, js engine: hermes
12-19 10:14:58.436 10249 10383 I ReactNativeJS: PRETTY PRINTED EXCEPTION
12-19 10:14:58.436 10249 10383 I ReactNativeJS: 
12-19 10:14:58.436 10249 10383 I ReactNativeJS: ***
12-19 10:14:58.436 10249 10383 I ReactNativeJS: NAME: "Error"
12-19 10:14:58.436 10249 10383 I ReactNativeJS: MESSAGE: Doesn't support name: 
12-19 10:14:58.436 10249 10383 I ReactNativeJS: 
12-19 10:14:58.436 10249 10383 I ReactNativeJS: Error: Doesn't support name: 
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at $f (address at index.android.bundle:1:4013989)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at OKd (address at index.android.bundle:1:7061711)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:7063303)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at call (native)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at Jca (address at index.android.bundle:1:3989388)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:7183299)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at lna (address at index.android.bundle:1:4091771)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:4092614)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at Cma (address at index.android.bundle:1:4085510)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at Sma (address at index.android.bundle:1:4087720)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at mna (address at index.android.bundle:1:4092390)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at kLd (address at index.android.bundle:1:4092855)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at renderWithHooks (address at index.android.bundle:1:8655867)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at beginWork$1 (address at index.android.bundle:1:8697753)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at performUnitOfWork (address at index.android.bundle:1:8684122)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at workLoopSync (address at index.android.bundle:1:8683983)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at renderRootSync (address at index.android.bundle:1:8683865)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at performSyncWorkOnRoot (address at index.android.bundle:1:8681276)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at flushSyncCallbacks (address at index.android.bundle:1:8645475)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at scheduleUpdateOnFiber (address at index.android.bundle:1:8678401)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at updateContainer (address at index.android.bundle:1:8689422)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:8698787)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at renderElement (address at index.android.bundle:1:8412610)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at renderApplication (address at index.android.bundle:1:8574256)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at run (address at index.android.bundle:1:8567750)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at runApplication (address at index.android.bundle:1:8568242)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at apply (native)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at __callFunction (address at index.android.bundle:1:8403644)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:8401976)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at __guard (address at index.android.bundle:1:8402931)
12-19 10:14:58.436 10249 10383 I ReactNativeJS:     at callFunctionReturnFlushedQueue (address at index.android.bundle:1:8401934)

Platforms

  • Android
  • iOS
Functional
  • wallet / transactions

Steps to test

  • Recover the user with some assets
  • Go to select asset screen (link of flow how to get this 'select asset' screen)
  • Tap any asset
  • Hopefully the error is not shown anymore

status: ready

@briansztamfater briansztamfater self-assigned this Dec 29, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Dec 29, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2e684b3 #1 2023-12-29 20:55:40 ~4 min tests 📄log
✔️ 2e684b3 #1 2023-12-29 20:57:02 ~6 min ios 📱ipa 📲
✔️ 2e684b3 #1 2023-12-29 20:57:31 ~6 min android-e2e 🤖apk 📲
✔️ 2e684b3 #1 2023-12-29 20:58:51 ~8 min android 🤖apk 📲
✔️ 832b6ef #2 2024-01-03 15:39:18 ~4 min tests 📄log
✔️ 832b6ef #2 2024-01-03 15:42:32 ~7 min android 🤖apk 📲
✔️ 832b6ef #2 2024-01-03 15:42:34 ~7 min android-e2e 🤖apk 📲
✔️ 832b6ef #2 2024-01-03 15:50:16 ~15 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4047e68 #3 2024-01-04 09:50:15 ~4 min tests 📄log
✔️ 4047e68 #3 2024-01-04 09:52:11 ~6 min android 🤖apk 📲
✔️ 4047e68 #3 2024-01-04 09:52:59 ~7 min android-e2e 🤖apk 📲
✔️ 4047e68 #3 2024-01-04 09:54:34 ~9 min ios 📱ipa 📲
✔️ b8d2694 #4 2024-01-04 14:53:07 ~4 min tests 📄log
✔️ b8d2694 #4 2024-01-04 14:54:19 ~6 min ios 📱ipa 📲
✔️ b8d2694 #4 2024-01-04 14:57:08 ~8 min android-e2e 🤖apk 📲
✔️ b8d2694 #4 2024-01-04 14:57:14 ~9 min android 🤖apk 📲

@briansztamfater briansztamfater mentioned this pull request Jan 3, 2024
Merged
@mariia-skrypnyk mariia-skrypnyk self-assigned this Jan 3, 2024
@status-im-auto
Copy link
Member

85% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Expected to fail tests: 4
Passed tests: 41

IDs of failed tests: 702782,702947,703629 

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Device 1: Tap on found: CommunitiesTab
    Device 2: Looking for a message by text: something to reply to 

    activity_center/test_activity_center.py:302: in test_activity_center_reply_read_unread_delete_filter_swipe
    self.channel_2.chat_element_by_text(message_to_reply).wait_for_visibility_of_element(120)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'something to reply to')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Looking for community: 'open community'
    Device 2: Click until Text by accessibility id: community-description-text will be presented 

    critical/chats/test_public_chat_browsing.py:1136: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 2: Find OpenInStatusButton by xpath: //*[@text="Open in Status"]
    Device 2: Tap on found: OpenInStatusButton 

    critical/chats/test_1_1_public_chats.py:175: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 URL was not opened from 1-1 chat



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (41)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @qoqobolo qoqobolo force-pushed the fix/error-asset-screen branch from 832b6ef to 4047e68 Compare January 4, 2024 09:45
    @mariia-skrypnyk mariia-skrypnyk mentioned this pull request Jan 4, 2024
    Closed
    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 1
Failed tests: 1
Expected to fail tests: 0
Passed tests: 0

    IDs of failed tests: 702782

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 2: Find `OpenInStatusButton` by `xpath`: `//*[@text="Open in Status"]`
    Device 2: Tap on found: OpenInStatusButton 

    critical/chats/test_1_1_public_chats.py:175: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 URL was not opened from 1-1 chat



    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @briansztamfater ! Thanks for your PR.

    Yes,hopefully the error is not shown anymore :)

    Please, merge your fix and rebase this PR
    Thanks a lot!

    @briansztamfater
    fix: error is shown when asset is selected on select assets screen
    b8d2694 
    Signed-off-by: Brian Sztamfater <brian@status.im>
    @briansztamfater briansztamfater merged commit 205962f into develop Jan 4, 2024
    6 checks passed
    @briansztamfater briansztamfater deleted the fix/error-asset-screen branch January 4, 2024 14:58
    @briansztamfater briansztamfater mentioned this pull request Jan 5, 2024
    Closed
    @ulisesmac ulisesmac mentioned this pull request Jan 16, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 left review comments

    @ulisesmac ulisesmac ulisesmac approved these changes

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @rasom rasom Awaiting requested review from rasom

    @vkjr vkjr Awaiting requested review from vkjr

    @smohamedjavid smohamedjavid Awaiting requested review from smohamedjavid

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @briansztamfater briansztamfater

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    An error is shown when asset is selected on select assets screen
    5 participants
    @briansztamfater @status-im-auto @mariia-skrypnyk @J-Son89 @ulisesmac