Drop clj-kondo dir from linting #18328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
siddarthkay
reviewed
Dec 30, 2023
siddarthkay
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Looks good to me, I would also like @ilmotta and @yqrashawn to have a look since they have context.
ilmotta
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Thanks @ibrkhalil.
We shouldn't ignore .clj-kondo/ entirely. The rule should be:
Only lint files under .clj-kondo/status-im/ and .clj-kondo/config.edn, the rest is assumed to be auto-generated from our dependencies and are out of our control.
Improved, Can you please take another look? |
ilmotta
approved these changes
Jan 8, 2024
yqrashawn
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17947
Summary
Adjusts the clojure file grep search pattern to not include files in ./clj-kondo when running
make lint-fixormake lintstatus: ready