Refactor composer #18339
Merged
Refactor composer #18339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parveshdhull
commented
Jan 2, 2024
src/js/worklets/chat/messages.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { useDerivedValue, withTiming, interpolate, useAnimatedScrollHandler, runOnJS } from 'react-native-reanimated'; | |||
| import { useDerivedValue, withTiming, interpolate, useAnimatedScrollHandler } from 'react-native-reanimated'; | |||
There was a problem hiding this comment.
this file is getting quite big, will refactor in next PR and will break in separate files (navigation, composer etc.)
Parveshdhull
commented
Jan 2, 2024
| @@ -281,7 +281,7 @@ | |||
|
|
|||
| (rf/defn close-and-remove-chat | |||
| "Closes the chat and removes it from chat list while retaining history, producing all necessary effects for that" | |||
| {:events [:chat.ui/close-chat]} | |||
There was a problem hiding this comment.
We also have :chat/close and this event is creating confusion
Jenkins BuildsClick to see older builds (20)
|
OmarBasem
approved these changes
Jan 2, 2024
Parveshdhull
force-pushed
the
chore/remove-floating-button-reagent-atom
branch
from
911adcf to
3590fce
Compare
Parveshdhull
force-pushed
the
chore/remove-floating-button-reagent-atom
branch
from
3590fce to
f7c909b
Compare
81% of end-end tests have passedFailed tests (6)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (39)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
Parveshdhull
force-pushed
the
chore/remove-floating-button-reagent-atom
branch
2 times, most recently
from
7b2c834 to
49f389f
Compare
|
Hi @Parveshdhull could you please resolve existing conflicts? |
Parveshdhull
force-pushed
the
chore/remove-floating-button-reagent-atom
branch
2 times, most recently
from
fcf4749 to
b87066d
Compare
71% of end-end tests have passedFailed tests (11)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (34)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
0% of end-end tests have passedFailed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
100% of end-end tests have passedPassed tests (2)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
hi @Parveshdhull thank you for your work. No issues from my side. PR is ready to be merged |
flexsurfer
approved these changes
Jan 9, 2024
- Removed show-floating-scroll-down-button? reagent atom
- Created event for scroll-to-bottom-fn
- Renamed chat.ui/close-chat
Parveshdhull
force-pushed
the
chore/remove-floating-button-reagent-atom
branch
from
b87066d to
3057b9f
Compare
briansztamfater
pushed a commit
that referenced
this pull request
Jan 11, 2024
- Removed show-floating-scroll-down-button? reagent atom - Created event for scroll-to-bottom-fn - Renamed chat.ui/close-chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
show-floating-scroll-down-button?reagent atomscroll-to-bottom-fnTesting (Please test for regressions)
status: ready