Wallet: Utility Tests #18371
Merged
Wallet: Utility Tests #18371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
requested review from
shivekkhurana,
vkjr,
briansztamfater,
smohamedjavid,
J-Son89,
mmilad75 and
ulisesmac
Jenkins BuildsClick to see older builds (49)
|
J-Son89
reviewed
Jan 3, 2024
| networks [{:chain-id :chain-1 :name "Network A"} | ||
| {:chain-id :chain-3 :name "Network C"}]] | ||
| (is (= (utils/network-list {:balances-per-chain balances-per-chain} networks) | ||
| #{:chain-1 :chain-3}))))) |
There was a problem hiding this comment.
just curious is :chain-1 etc abitrary? this is normally the chain id? e.g :1 ?
There was a problem hiding this comment.
@J-Son89 yes the chain id like :1. I think the values used in tests don't matter much as long as the test returns the correct value, but I can update it to :1 👍
There was a problem hiding this comment.
actually we are transforming (or we should) to 1 instead.
it is important to keep the type because a function could break if we don't provide the proper one (such as the common exception name not supported).
J-Son89
approved these changes
Jan 4, 2024
OmarBasem
force-pushed
the
wallet/utils-test
branch
from
f85630d to
fad78ca
Compare
ulisesmac
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Thanks for this PR @OmarBasem !
Some of our utility functions are being used by our subscriptions, and our subs have tests, so just let's be careful about it, we don't need to double test a function, we could instead improve the existing one, although adding extra tests isn't bad.
| [balances-per-chain] | ||
| (println "calling totalxxx", balances-per-chain) |
Thanks for notifying me about this. Having tests for individual utility functions is still good to have as they may be used for other functions/subs |
OmarBasem
force-pushed
the
wallet/utils-test
branch
2 times, most recently
from
b7e0d6a to
1b965f6
Compare
OmarBasem
force-pushed
the
wallet/utils-test
branch
from
0bed5ed to
68cd4e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18370
This PR adds tests for all utility functions under
status-im.contexts.wallet.common.utils