chore: organise chats context #18373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
J-Son89
requested review from
flexsurfer,
ilmotta,
OmarBasem,
Parveshdhull and
alwx
and removed request for
flexsurfer and
ilmotta
J-Son89
force-pushed
the
jc/organise-chat
branch
from
f576920 to
a4bad6d
Compare
Parveshdhull
approved these changes
Jan 3, 2024
OmarBasem
reviewed
Jan 3, 2024
| (ns status-im.contexts.chat.new-chat.view | ||
| (ns status-im.contexts.chat.home.new-chat.view |
There was a problem hiding this comment.
Is it only one file that needs to be under home ?
There was a problem hiding this comment.
Not sure exactly what you mean here?
There was a problem hiding this comment.
chat/home - any folder which may be used in the home page
I only see one file (and its style) under contexts.chat.home
There was a problem hiding this comment.
In this pr, under home there is
add_new_contact,
chat_list_item,
new_chat,
contact_request,
view (main entry point)
Happy to restructure it more
There was a problem hiding this comment.
checked Github with this branch:
There was a problem hiding this comment.
Oh okay fine, these files weren't showing as changes cause they were already under a home namespace
OmarBasem
approved these changes
Jan 4, 2024
ilmotta
approved these changes
Jan 5, 2024
J-Son89
force-pushed
the
jc/organise-chat
branch
from
a4bad6d to
afe626d
Compare
|
@status-im/mobile-qa - this pr is just moving files and nothing is addde/removed here in the code. |
52% of end-end tests have passedFailed tests (21)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (25)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
|
|
@status-im/mobile-qa - can someone take a look at these test results and let me know if they are ok? :) |
@J-Son89 they are not ok 😂 |
haha, yeah I am never too sure of what margin to expect. Actually I see the unit/integration tests are failing. Let me check/fix that first! |
J-Son89
force-pushed
the
jc/organise-chat
branch
from
afe626d to
b180c79
Compare
Okay, removing PR from the queue for now. Let me know when it's ready |
|
@qoqobolo - seems good now. I rebased. Also checked the tests locally and they passed, I think it was just something flaky there. |
|
@J-Son89 okay thanks, restarting e2e |
95% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Passed tests (20)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
|
|
@J-Son89 now they are okay :) |
J-Son89
force-pushed
the
jc/organise-chat
branch
from
b180c79 to
88c3a35
Compare
|
Thanks @qoqobolo! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re organised the files within the Chat context.
The general idea is to have
chat/ <common-pieces> - any folder which may be used in both the home page and the messenger page
chat/home - any folder which may be used in the home page
chat/messenger - any folder which may be used in the messenger page
Notes:
Some further refactoring should be done to further separate the events for all of these. In general the Chat files are quite bunched in together and should be separated for maintainability. Often there is large files with multiple exports and it is hard to know what/where/how some files are being used.
Testing notes: Nothing is added or removed in this pr, I am just moving the location of files around.