Wallet - Initialize event, refactor networks data and bug fix #18374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
smohamedjavid
requested review from
shivekkhurana,
vkjr,
briansztamfater,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
J-Son89
reviewed
Jan 3, 2024
| @@ -60,11 +59,6 @@ | |||
| :<- [:wallet/wallet-send] | |||
| :-> :token) | |||
|
|
|||
| (rf/reg-sub | |||
There was a problem hiding this comment.
you sure you should delete this?
There was a problem hiding this comment.
I checked for the usage. It's an unused subscription.
If it's needed, I will revert it 👍
There was a problem hiding this comment.
aha, actually I think this is a duplicate. 🤔
In this pr https://github.com/status-im/status-mobile/pull/18242/files#diff-8bd46e272f87626708b0cb26f20ee2f21d87c4d3197fd2e761a751cac235e9f3 I moved it to src/status_im/subs/wallet/send.cljs
There was a problem hiding this comment.
No worries if it's handled. I will revert this part. 👍
J-Son89
reviewed
Jan 3, 2024
| vals | ||
| (map #(assoc-network-preferences-names network-details % testnet?)) | ||
| (sort-by :position))))) | ||
| :<- [:profile/test-networks-enabled?] |
smohamedjavid
force-pushed
the
chore/wallet-refactor
branch
from
0e0a488 to
2d13273
Compare
ulisesmac
reviewed
Jan 4, 2024
Comment on lines
-222
to
+204
| {:db (assoc db :wallet/networks network-data)}))) | ||
| {:db (assoc-in db [:wallet :networks] network-data)}))) |
ulisesmac
approved these changes
Jan 4, 2024
Comment on lines
6
to
+16
| (re-frame/reg-sub | ||
| :wallet/filtered-networks-by-mode | ||
| :wallet/networks | ||
| :<- [:wallet] | ||
| :-> :networks) | ||
|
|
||
| (re-frame/reg-sub | ||
| :wallet/networks-by-mode | ||
| :<- [:wallet/networks] | ||
| (fn [networks [_ test?]] | ||
| (get networks (if test? :test :prod)))) | ||
| :<- [:profile/test-networks-enabled?] | ||
| (fn [[networks test-networks-enabled?]] | ||
| (get networks (if test-networks-enabled? :test :prod)))) |
OmarBasem
approved these changes
Jan 5, 2024
smohamedjavid
force-pushed
the
chore/wallet-refactor
branch
from
2d13273 to
6a76c21
Compare
81% of end-end tests have passedFailed tests (7)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (39)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
|
briansztamfater
approved these changes
Jan 7, 2024
smohamedjavid
force-pushed
the
chore/wallet-refactor
branch
from
6a76c21 to
d4375ca
Compare
0% of end-end tests have passedFailed tests (47)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
29% of end-end tests have passedFailed tests (33)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (14)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
|
82% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (27)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
50% of end-end tests have passedFailed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
Thanks @smohamedjavid, LGTM! |
smohamedjavid
force-pushed
the
chore/wallet-refactor
branch
from
d4375ca to
e9623a2
Compare
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
chore/wallet-refactor
branch
from
e9623a2 to
0e86e54
Compare
briansztamfater
pushed a commit
that referenced
this pull request
Jan 11, 2024
This commit: - Introduces new event ":wallet/initialize" to group events that need to be called on login - Refactors wallet networks to use the nested structure in re-frame - Fixes a bug when updating the testnet network preferences of an account the production network preferences update --------- Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17985
fixes #18368
Summary
This PR:
:wallet/initializeto group events that need to be called on loginPlatforms
Steps to test
Please do a quick test of the wallet, as this PR does a minor refactor.
To test the bug fix
status: ready