Wallet: suggested routes list #18388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
commented
Jan 4, 2024
OmarBasem
requested review from
shivekkhurana,
vkjr,
smohamedjavid,
J-Son89 and
mmilad75
Jenkins BuildsClick to see older builds (29)
|
|
actually I think with issue #18386 the better approach might be to use the floating_button_page component as this will handle the case for small screens too. see this pr for reference: https://github.com/status-im/status-mobile/pull/18242/files#diff-959b270ac3c6ceb08c98144bdf50aa950611b15dbe84980db438b1664dca473e |
OmarBasem
force-pushed
the
wallet/suggested-routes-1.2
branch
from
87cb0bc to
3661446
Compare
@J-Son89 fixed 👍 |
J-Son89
reviewed
Jan 8, 2024
| [route-item | ||
| {:amount amount | ||
| :status :default | ||
| :from-network (utils/id->network (get-in route [:From :chainId])) |
There was a problem hiding this comment.
are the data in routes still upper case? I think I might have addressed this in a recent pr I merged 🤔 so it should be :from and chain-id
J-Son89
reviewed
Jan 8, 2024
| [account-switcher/view | ||
| {:on-press on-close | ||
| :switcher-type :select-account}] | ||
| [floating-button-page/view |
There was a problem hiding this comment.
@OmarBasem just to check for feedback, this component was working alright etc? does it need any updates etc?
There was a problem hiding this comment.
@J-Son89 it is working fine. Just one thing, why are we not using insets from navigation instead of having to apply margin-top https://github.com/status-im/status-mobile/pull/18388/files#diff-1fc8418ccf535f4dd924ee5e62463e5359e24b383c052afc4ab39d40c645d465R22-R24
J-Son89
approved these changes
Jan 8, 2024
0% of end-end tests have passedFailed tests (47)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
OmarBasem
force-pushed
the
wallet/suggested-routes-1.2
branch
from
3661446 to
4c38c82
Compare
81% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
56% of end-end tests have passedFailed tests (19)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (27)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
65% of end-end tests have passedFailed tests (14)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (31)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
OmarBasem
force-pushed
the
wallet/suggested-routes-1.2
branch
from
99f96e1 to
d7b8c56
Compare
OmarBasem
force-pushed
the
wallet/suggested-routes-1.2
branch
from
f39c9f4 to
b98268c
Compare
briansztamfater
pushed a commit
that referenced
this pull request
Jan 11, 2024
* wallet: suggested routes list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18387, #18386
This PR implements the list of the suggested routes on the send screen. Also fixes a UI bug (misplaced button on the send screen).
Demo:
Screen_Recording_20240104_125100_Status.mp4