Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix improper use of current-chat-id and rename subs #18389

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix improper use of current-chat-id and rename subs #18389

merged 1 commit into from
Jan 11, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jan 4, 2024 •
edited
Loading

fixes #18391

Summary

  • Removes use :current-chat-id just for checking group details
  • Removes use of anonymous function in functional component
  • Fixes names of subscriptions

Testing

Please make sure management of group is working fine (removing, adding of members etc.)

status: ready

@Parveshdhull Parveshdhull self-assigned this Jan 4, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jan 4, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e59ccf6 #1 2024-01-04 09:31:12 ~4 min tests 📄log
✔️ e59ccf6 #1 2024-01-04 09:33:37 ~7 min android-e2e 🤖apk 📲
✔️ e59ccf6 #1 2024-01-04 09:34:24 ~8 min android 🤖apk 📲
✔️ e59ccf6 #1 2024-01-04 09:36:01 ~9 min ios 📱ipa 📲
✔️ 2453b77 #2 2024-01-04 10:21:47 ~4 min tests 📄log
✔️ 2453b77 #2 2024-01-04 10:24:34 ~7 min android 🤖apk 📲
✔️ 2453b77 #2 2024-01-04 10:24:54 ~7 min android-e2e 🤖apk 📲
✔️ 2453b77 #2 2024-01-04 10:27:41 ~10 min ios 📱ipa 📲
✔️ fffe947 #3 2024-01-08 07:38:49 ~6 min ios 📱ipa 📲
✔️ fffe947 #3 2024-01-08 07:38:53 ~6 min tests 📄log
✔️ fffe947 #3 2024-01-08 07:39:44 ~6 min android 🤖apk 📲
✔️ fffe947 #3 2024-01-08 07:40:27 ~7 min android-e2e 🤖apk 📲
✔️ c755025 #4 2024-01-10 09:39:18 ~5 min tests 📄log
✔️ c755025 #4 2024-01-10 09:41:42 ~8 min ios 📱ipa 📲
✔️ c755025 #4 2024-01-10 09:42:00 ~8 min android-e2e 🤖apk 📲
✔️ c755025 #4 2024-01-10 09:42:39 ~9 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d205f9b #5 2024-01-10 17:42:03 ~5 min tests 📄log
✔️ d205f9b #5 2024-01-10 17:42:33 ~6 min ios 📱ipa 📲
✔️ d205f9b #5 2024-01-10 17:43:14 ~6 min android-e2e 🤖apk 📲
✔️ d205f9b #5 2024-01-10 17:44:21 ~7 min android 🤖apk 📲
✔️ 15d0b8c #6 2024-01-11 11:42:12 ~5 min tests 📄log
✔️ 15d0b8c #6 2024-01-11 11:42:52 ~6 min ios 📱ipa 📲
✔️ 15d0b8c #6 2024-01-11 11:43:30 ~7 min android 🤖apk 📲
✔️ 15d0b8c #6 2024-01-11 11:43:57 ~7 min android-e2e 🤖apk 📲

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 48
Failed tests: 8
Expected to fail tests: 4
Passed tests: 36

IDs of failed tests: 702809,703133,702957,702948,702786,702845,702958,703629 

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    3. test_community_mentions_push_notification, id: 702786

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (36)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    @Parveshdhull Parveshdhull force-pushed the chore/dont-open-chat-just-for-checking-details branch from e59ccf6 to 2453b77 Compare January 4, 2024 10:17
    @pavloburykh
    Copy link
    Contributor

    @Parveshdhull thanks for the PR. Failed e2e are known and not related to the PR.

    @Parveshdhull Parveshdhull mentioned this pull request Jan 4, 2024
    Closed
    @Parveshdhull Parveshdhull marked this pull request as draft January 4, 2024 10:43
    @Parveshdhull Parveshdhull changed the title fix improper use of current-chat-id and rename subs [WIP] fix improper use of current-chat-id and rename subs Jan 4, 2024
    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented Jan 4, 2024 •
    edited
    Loading

    hi @pavloburykh,

    Thank you very much for checking the e2e tests. But it looks currently adding-removing members from home screen is not working because not only group details screen but most of the events related to management of group are also relying on current-chat-id.

    PR will also going to need manual-qa-testing as bug is more complicated then it initially looked. Will ping qa once PR is ready to test.

    @Parveshdhull Parveshdhull force-pushed the chore/dont-open-chat-just-for-checking-details branch from 2453b77 to fffe947 Compare January 8, 2024 07:32
    @Parveshdhull Parveshdhull marked this pull request as ready for review January 8, 2024 07:32
    @Parveshdhull Parveshdhull changed the title [WIP] fix improper use of current-chat-id and rename subs fix improper use of current-chat-id and rename subs Jan 8, 2024
    @status-im-auto
    Copy link
    Member

    88% of end-end tests have passed

    Total executed tests: 48
Failed tests: 3
Expected to fail tests: 3
Passed tests: 42

    IDs of failed tests: 703133,702948,702745 

    IDs of expected to fail tests: 703503,702808,703629

    Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]`
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1088: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not all channels are shown in community before joining: ['dogs']



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Tap on found: Button
    Device 1: Find ProfilePictureElement by accessibility id: chat-icon 

    critical/chats/test_1_1_public_chats.py:270: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.profile_1.edit_profile_picture(image_index=2)
../views/profile_view.py:443: in edit_profile_picture
    self.profile_picture.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ProfilePictureElement by accessibility id: `chat-icon` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1175: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 open community is not listed inside Pending communities tab
E    Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"
E    Joined status is not displayed
E    open community is not listed inside Joined communities tab

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (42)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @Parveshdhull Parveshdhull force-pushed the chore/dont-open-chat-just-for-checking-details branch from fffe947 to c755025 Compare January 10, 2024 09:33
    @Parveshdhull
    Copy link
    Member Author

    No new changes, just rebased PR.

    @qoqobolo qoqobolo self-assigned this Jan 10, 2024
    @qoqobolo
    Copy link
    Contributor

    @Parveshdhull thanks for PR!
    I see three issues with the group chat members management atm, one of them is only in PR and the other two in nightly.

    But it looks currently adding-removing members from home screen is not working because not only group details screen but most of the events related to management of group are also relying on current-chat-id.

    By this, did you mean that in this PR we need to check that everything works the same as in nightly, or that you also fix other issues related to the group management (in this case, we'll log the last two separately)?

    ISSUE 1 (PR only): Group members list is not displayed in group details anymore

    PR
    Screenshot 2024-01-10 at 17 27 32

    Nightly
    Screenshot 2024-01-10 at 17 27 57

    ISSUE 2 (nightly and PR): Non-admin can "remove" a group member

    Steps:

    1. UserA adds UserB and UserC to contacts and creates a group
    2. UserC removes UserA or UserB from the group

    In this case, the UI behaves weirdly: the system message UserC has added appears, and UserA is not removed from the group in fact.

    Screenshot 2024-01-10 at 17 57 57
    video_2024-01-10_17-58-04.mp4

    As I can see from Figma a non-admin should not have this ability to remove user, but I might be wrong. Do you know for sure? If not, we can check this with the designers.

    ISSUE 3 (nightly and PR): Name of a new member is not displayed in the system message for other users if they are not contacts / before receiving first message from the new member

    Steps:

    1. UserA adds UserB and UserC to contacts and creates a group
    2. UserC adds UserD to contacts and adds them to the group

    This is how looks for UserA and UserB:
    Screenshot 2024-01-10 at 18 06 34

    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented Jan 10, 2024 •
    edited
    Loading

    Hi @qoqobolo, Thank you very much for testing the PR and finding these issues.

    did you mean that in this PR we need to check that everything works the same as in nightly, or that you also fix other issues related to the group management (in this case, we'll log the last two separately)?

    Sorry for the confusion, I meant please check everything works the same as in nightly + fixes the linked bug #18391

    So, yes please log last two issues separately. Issue 1 should be fixed now.

    @qoqobolo
    Copy link
    Contributor

    Thanks for the fixes @Parveshdhull!
    Don't see any other issues, PR can be merged.
    Nightly issues will be logged separately.

    @Parveshdhull Parveshdhull force-pushed the chore/dont-open-chat-just-for-checking-details branch from d205f9b to 15d0b8c Compare January 11, 2024 11:36
    @Parveshdhull Parveshdhull merged commit 623d4a1 into develop Jan 11, 2024
    6 checks passed
    @Parveshdhull Parveshdhull deleted the chore/dont-open-chat-just-for-checking-details branch January 11, 2024 11:50
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @Parveshdhull Parveshdhull

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Group messages are automatically getting marked read
    5 participants
    @Parveshdhull @status-im-auto @pavloburykh @qoqobolo @ibrkhalil