-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed spacing between the header and illustration on biometrics page #18402
Conversation
Jenkins BuildsClick to see older builds (22)
|
8697242
to
965459f
Compare
965459f
to
b912008
Compare
27% of end-end tests have passed
Failed tests (32)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Expected to fail tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (13)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
|
d93a79e
to
25bc541
Compare
25bc541
to
8aeacbb
Compare
@mariia-skrypnyk this too requires design review. @Francesca-G you could take a look at this please |
@Francesca-G after reviewing our pr approval process here https://discord.com/channels/1103692771585433630/1103692773363810317/1134494371132227644 I may have involved you a bit early in review my prs. Kindly just ignore my request until the QA is okay with them. Thank you |
@jo-mut thanks for your PR! I've checked on both iOS and Android builds and vertical padding looks bigger now. Great job! |
58% of end-end tests have passed
Failed tests (18)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (28)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ✨
8aeacbb
to
18859ae
Compare
18859ae
to
a207283
Compare
fixes #17500
Summary
Updates the vertical padding for the
text-combinations
component as used in the biometric screen and also adds a padding-top to the parallax video container on this screen.I also noticed on develop this screen does not have the page-nav but thats not the case with the designs. I wonder if its just a bug or its on purpose?.
Android Before & After
iOS Before & After
Figma