Enable user to share wallet address #18424

Pau1fitz · 2024-01-06T20:43:00Z

Fixes #17865

Share Screen -> Implement Share Wallet Address

Screen.Recording.2024-01-06.at.21.29.07.mov

Figma design

iOS
Android

Testing notes:
Navigate to the share screen
click on Wallet
user can see each wallet that to share address

Pau1fitz · 2024-01-06T20:43:52Z

src/status_im/contexts/shell/share/profile/view.cljs

@@ -0,0 +1,75 @@
+(ns status-im.contexts.shell.share.profile.view


Created a new file share/profile/view and moved the profile code below, that was previously in share/view, to improve code organization and readability.

src/status_im/contexts/shell/share/wallet/view.cljs

Pau1fitz · 2024-01-06T21:13:54Z

src/status_im/contexts/shell/share/view.cljs

@@ -1,18 +1,14 @@
 (ns status-im.contexts.shell.share.view
  (:require
-    [clojure.string :as string]


The removed code in this file was moved to the new file above - share/profile/view

pavloburykh · 2024-01-11T13:03:01Z

Thanks @pavloburykh you are right.

Do we always want to open in a new window tho? I am thinking if the current profile sharing behaviour should be on top of the current window? 🤔

If we do it on top of the current window (like it is currently implemented in this PR) user stays in the selected app and is not even redirected back to Status share screen after sending wallet address. That does not look user friendly IMO. Because in this case user needs to tap system back button couple of times until he is returned to initial Share wallet screen. Also It looks weird that after sharing wallet address User can continue interacting with selected app that is opened on top of Status app window.

J-Son89 · 2024-01-11T13:27:14Z

Thanks @pavloburykh you are right.

Do we always want to open in a new window tho? I am thinking if the current profile sharing behaviour should be on top of the current window? 🤔

If we do it on top of the current window (like it is currently implemented in this PR) user stays in the selected app and is not even redirected back to Status share screen after sending wallet address. That does not look user friendly IMO. Because in this case user needs to tap system back button couple of times until he is returned to initial Share wallet screen. Also It looks weird that after sharing wallet address User can continue interacting with selected app that is opened on top of Status app window.

@OmarBasem, is this a common issue to the wallet share screens? If so perhaps it is beyond the scope of this pr? 🤔

pavloburykh · 2024-01-11T13:38:44Z

@OmarBasem, is this a common issue to the wallet share screens? If so perhaps it is beyond the scope of this pr? 🤔

@J-Son89 if by "wallet share screen" you mean this screen below - then the answer is yes. ISSUE 1 and ISSUE 3 are common. So probably those issues can be handled separately, not in scope of this PR.

J-Son89 · 2024-01-11T13:41:22Z

@OmarBasem, is this a common issue to the wallet share screens? If so perhaps it is beyond the scope of this pr? 🤔

@J-Son89 if by "wallet share screen" you mean this screen below - then the answer is yes. ISSUE 1 and ISSUE 3 are common. So probably those issues can be handled separately, not in scope of this PR.

Thanks @pavloburykh - yes exactly, I mean those screens. Ok perfect, sounds good 👌

pavloburykh · 2024-01-11T13:43:32Z

Okay, so do I understand correctly that among all above issues we want to fix only ISSUE 2 in scope of this PR? Or ISSUE 2 is also considered not to be in scope? @OmarBasem @J-Son89

J-Son89 · 2024-01-11T13:45:34Z

Okay, so do I understand correctly that among all above issues we want to fix only ISSUE 2 in scope of this PR? Or ISSUE 2 is also considered not to be in scope? @OmarBasem @J-Son89

Oh issue 2 looks related to this pr 👌

Pau1fitz · 2024-01-11T16:04:19Z

@J-Son89 Issue 1 has been fixed and tested by @pavloburykh

Pau1fitz · 2024-01-11T16:07:04Z

@J-Son89 Issue 3 has also been fixed and tested by @pavloburykh

status-im-auto · 2024-01-11T17:42:10Z

77% of end-end tests have passed

Total executed tests: 48
Failed tests: 9
Expected to fail tests: 2
Passed tests: 37

IDs of failed tests: 702845,702947,702958,702786,702809,702948,703629,702957,702936

IDs of expected to fail tests: 702808,703503

Failed tests (9)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: activity_center/test_activity_center.py:270: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
2. test_navigation_jump_to, id: 702936
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Wait for element `Button` for max 120s and click when it is available Test setup failed: activity_center/test_activity_center.py:270: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
2. test_community_mentions_push_notification, id: 702786
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Wait for element `Button` for max 120s and click when it is available Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
4. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
2. test_activity_center_mentions, id: 702957
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Wait for element `Button` for max 120s and click when it is available Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices self.community_2.join_community() ../views/chat_view.py:435: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (2)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (37)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs

pavloburykh · 2024-01-11T17:53:21Z

Thank you @Pau1fitz

So, here the summury:

ISSUE 1 and 3 are fixed.
ISSUE 4 and 5 will be fixed in #18452 and #18454

ISSUE 2 is fixed partially: still can scroll QR up and down. We agreed to log this issue separately as it is device/IOS specific.

telegram-cloud-document-2-5260607374435044659.mp4

PR is ready for merge.

J-Son89 · 2024-01-15T12:10:36Z

@Pau1fitz - I think you have to sign commits for the pr to be merged https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Pau1fitz · 2024-01-15T14:17:53Z

@J-Son89 I spoke to @flexsurfer about this and I am happy for a core dev to merge this on my behalf.

J-Son89 · 2024-01-15T14:40:11Z

merged here: #18511

Pau1fitz added 18 commits January 4, 2024 14:09

loop over wallet addresses

6c685e1

correctly render component

221dd11

show all wallets and enable scrolling

1fff5c8

fix width in scroll view

56ba0c3

Merge branch 'develop' into 17865-share-wallet-address

b698535

add key to correct element

da6649a

separate out components

604b7b8

run make lint

f2a97be

setup tests

cba47c7

update view

15c004f

add tests

14a07ae

width fix

31e1c24

update tests

2cb8992

remove type from test

b38ef6b

revert makefile

d7e6670

remove line break

2e14503

remove unneeded flex

12cc8a7

remove line break

0eb49ba

Pau1fitz changed the title ~~17865 share wallet address~~ Enable user to share wallet address Jan 6, 2024

Merge branch 'develop' into 17865-share-wallet-address

8b5bb0b

Pau1fitz commented Jan 6, 2024

View reviewed changes

src/status_im/contexts/shell/share/wallet/view.cljs Show resolved Hide resolved

update test description

ea9a82e

Pau1fitz commented Jan 6, 2024

View reviewed changes

add line break in test file

e64cb08

siddarthkay added the external label Jan 7, 2024

siddarthkay requested review from flexsurfer, yqrashawn and siddarthkay January 8, 2024 07:16

Pau1fitz added 4 commits January 11, 2024 14:31

fix share issue

41befe6

Merge branch 'develop' into 17865-share-wallet-address

f3b2edb

lint

2a17780

add directional

1d7eaa5

pavloburykh mentioned this pull request Jan 11, 2024

Enable user to share community channel #18271

Closed

pavloburykh added the Tested - OK label Jan 11, 2024

Pau1fitz added 2 commits January 11, 2024 18:48

Merge branch 'develop' into 17865-share-wallet-address

eb31586

Merge branch 'develop' into 17865-share-wallet-address

3eb86f8

Pau1fitz mentioned this pull request Jan 13, 2024

Add background color to qr code #18482

Closed

line

a65f584

Merge branch 'develop' into 17865-share-wallet-address

f71887e

J-Son89 mentioned this pull request Jan 15, 2024

Pf share #18511

Merged

J-Son89 closed this Jan 15, 2024

pavloburykh added test cases added and removed test cases required labels Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable user to share wallet address #18424

Enable user to share wallet address #18424

Pau1fitz commented Jan 6, 2024 •

edited

Loading

Pau1fitz Jan 6, 2024 •

edited

Loading

Pau1fitz Jan 6, 2024 •

edited

Loading

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 11, 2024

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 11, 2024

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 11, 2024

Pau1fitz commented Jan 11, 2024 •

edited

Loading

Pau1fitz commented Jan 11, 2024 •

edited

Loading

status-im-auto commented Jan 11, 2024

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 15, 2024

Pau1fitz commented Jan 15, 2024

J-Son89 commented Jan 15, 2024

		@@ -0,0 +1,75 @@
		(ns status-im.contexts.shell.share.profile.view

Enable user to share wallet address #18424

Enable user to share wallet address #18424

Conversation

Pau1fitz commented Jan 6, 2024 • edited Loading

Pau1fitz Jan 6, 2024 • edited Loading

Choose a reason for hiding this comment

Pau1fitz Jan 6, 2024 • edited Loading

Choose a reason for hiding this comment

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 11, 2024

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 11, 2024

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 11, 2024

Pau1fitz commented Jan 11, 2024 • edited Loading

Pau1fitz commented Jan 11, 2024 • edited Loading

status-im-auto commented Jan 11, 2024

77% of end-end tests have passed

Failed tests (9)

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Expected to fail tests (2)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Passed tests (37)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

pavloburykh commented Jan 11, 2024

J-Son89 commented Jan 15, 2024

Pau1fitz commented Jan 15, 2024

J-Son89 commented Jan 15, 2024

Pau1fitz commented Jan 6, 2024 •

edited

Loading

Pau1fitz Jan 6, 2024 •

edited

Loading

Pau1fitz Jan 6, 2024 •

edited

Loading

Pau1fitz commented Jan 11, 2024 •

edited

Loading

Pau1fitz commented Jan 11, 2024 •

edited

Loading