[Fix] Currency on recovered profile #18433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohamedjavid
requested review from
vkjr,
flexsurfer,
qfrank,
briansztamfater,
J-Son89 and
OmarBasem
Jenkins BuildsClick to see older builds (14)
|
J-Son89
reviewed
Jan 8, 2024
| @@ -51,3 +51,10 @@ | |||
| (visibility-status-updates/<-rpc-settings) | |||
| (set/rename-keys {:compressedKey :compressed-key | |||
| :emojiHash :emoji-hash}))) | |||
|
|
|||
| (defn rpc->setting-value | |||
There was a problem hiding this comment.
is there any reason we need to have this in legacy folder? seems like something we can move to profile/datastore.cljs ?
There was a problem hiding this comment.
and start the migration! :)
There was a problem hiding this comment.
is there any reason we need to have this in legacy folder? seems like something we can move to profile/datastore.cljs ?
I placed it in the legacy.* ns as the RPC data helpers for settings are used from it.
Moving the data-store for settings to status-im.* ns would be easy when we do it.
cc @flexsurfer
qfrank
approved these changes
Jan 9, 2024
smohamedjavid
force-pushed
the
fix/currency-on-recovered-profile
branch
from
0cd2c12 to
a1d2179
Compare
✔️ status-mobile/prs/android-e2e/PR-18433#2 🔹 ~6 min 50 sec 🔹 a1d2179 🔹 📦 android-e2e package |
smohamedjavid
force-pushed
the
fix/currency-on-recovered-profile
branch
2 times, most recently
from
53c7d5d to
695f9cd
Compare
smohamedjavid
force-pushed
the
fix/currency-on-recovered-profile
branch
from
695f9cd to
8c763ce
Compare
90% of end-end tests have passedFailed tests (2)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
|
|
Hi @smohamedjavid thank you for PR. No issues from my side. PR can be merged |
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
fix/currency-on-recovered-profile
branch
from
8c763ce to
c6d2483
Compare
Pau1fitz
pushed a commit
to Pau1fitz/status-mobile
that referenced
this pull request
Jan 22, 2024
This commit fixes the currency symbol not shown on the recovered profile. -- Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18199
Summary
This PR fixes the currency symbol not shown on the recovered profile.
Review Notes
The bug is caused by to assoc setting value without data sanitization.
Platforms
Steps to test
status: ready