Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: boost checksum issue due to jfrog #18434

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: boost checksum issue due to jfrog #18434

merged 1 commit into from
Jan 8, 2024

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Jan 8, 2024 •
edited
Loading

I tried doing a clean pod install and was faced with this :

Installing Yoga (1.14.0)
Installing boost (1.76.0)

[!] Error installing boost
Verification checksum was incorrect, expected 
f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41, got 
5e89103d9b70bba5c91a794126b169cb67654be2051f90cf7c22ba6893ede0ff

related issue in react-native repo : facebook/react-native#42180

In this PR we patch the pod specs provided by react native to rely on sourceforge instead jfrog to get boost.

Platforms

  • iOS

status: ready

@siddarthkay siddarthkay self-assigned this Jan 8, 2024
@siddarthkay siddarthkay requested a review from jakubgs as a code owner January 8, 2024 18:02
@status-im-auto
Copy link
Member

status-im-auto commented Jan 8, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 16eb02d #1 2024-01-08 18:08:31 ~5 min tests 📄log
✔️ 16eb02d #1 2024-01-08 18:10:27 ~7 min android 🤖apk 📲
✔️ 16eb02d #1 2024-01-08 18:10:29 ~7 min android-e2e 🤖apk 📲
✔️ 16eb02d #1 2024-01-08 18:11:59 ~9 min ios 📱ipa 📲

jakubgs
jakubgs approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is most probably temporary so it's fine.

But it would be nice to fetch Cocoapod dependencies using Nix too.

@siddarthkay
Copy link
Contributor Author

@status-im/mobile-qa : merging without manual QA and E2E, since these changes affect iOS build only.

@siddarthkay siddarthkay merged commit f992f4a into develop Jan 8, 2024
6 of 7 checks passed
@siddarthkay siddarthkay deleted the ditch-jfrog-for-boost branch January 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

Assignees

@siddarthkay siddarthkay

Labels
skip-manual-qa
Projects
Pipeline for QA
Archived in project
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddarthkay @status-im-auto @jakubgs