Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add back missing clj-kondo config files #18472

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Jan 11, 2024

Fixes #17947

Summary

This PR should fix our issues with auto-generated clj-kondo config files. The code in develop is actually correct, we just forgot to add back some files.

  • To be extra precise, we now exclude .clj-kondo/* from being processed by clojure-lsp clean-ns.
  • Formatted the .zprintrc file. Whenever I touched that file it was completely reformatted by zprint because I have Emacs configured to format after saving.

For reviewers

Please, confirm running make lint-fix in your machine doesn't make the stage dirty.

Steps to test

Nothing to test.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jan 11, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 27424a5 #1 2024-01-11 16:02:12 ~5 min tests 📄log
✔️ 27424a5 #1 2024-01-11 16:03:51 ~7 min android-e2e 🤖apk 📲
✔️ 27424a5 #1 2024-01-11 16:04:09 ~7 min android 🤖apk 📲
✔️ 27424a5 #1 2024-01-11 16:18:56 ~22 min ios 📱ipa 📲
✔️ 44d4d6d #2 2024-01-11 23:16:38 ~5 min tests 📄log
✔️ 44d4d6d #2 2024-01-11 23:16:40 ~5 min ios 📱ipa 📲
✔️ 44d4d6d #2 2024-01-11 23:18:07 ~7 min android 🤖apk 📲
✔️ 44d4d6d #2 2024-01-11 23:18:52 ~7 min android-e2e 🤖apk 📲

@ibrkhalil
Copy link
Contributor

Checkout and ran make lint-fix on Ubuntu and it's working beautifully.

Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ilmotta ilmotta force-pushed the fix/cljkondo-config-files branch from 27424a5 to 44d4d6d Compare January 11, 2024 23:10
@ilmotta ilmotta merged commit a14e228 into develop Jan 11, 2024
6 checks passed
@ilmotta ilmotta deleted the fix/cljkondo-config-files branch January 11, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

check in taoensso and babashka inside ./clj-kondo into version control but prevent them from being formatted
6 participants