feat: add ability to send collectibles from wallet #18473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
requested review from
shivekkhurana,
rasom,
vkjr,
smohamedjavid,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
Jenkins BuildsClick to see older builds (19)
|
briansztamfater
force-pushed
the
feat/send-collectible-events-4
branch
2 times, most recently
from
eb19ad5 to
9077ae9
Compare
smohamedjavid
approved these changes
Jan 11, 2024
| @@ -40,25 +40,35 @@ | |||
| (update-in [:wallet :ui :send] dissoc :route) | |||
| (update-in [:wallet :ui :send] dissoc :loading-suggested-routes?))})) | |||
|
|
|||
| (rf/reg-event-fx :wallet/select-send-account-address | |||
| (fn [{:keys [db]} [{:keys [address stack-id]}]] | |||
| (rf/reg-event-fx :wallet/clean-send-address | |||
src/status_im/contexts/wallet/send/transaction_confirmation/view.cljs
Outdated
Show resolved
Hide resolved
ulisesmac
force-pushed
the
16978-select-collectible
branch
from
52b5e99 to
9f59f1b
Compare
OmarBasem
reviewed
Jan 12, 2024
Comment on lines
-36
to
52
| (when (pos? ethereum) | ||
| (when (and ethereum (pos? (:amount ethereum))) | ||
| [network-amount | ||
| {:network :ethereum | ||
| :amount (str ethereum " ETH") | ||
| :amount (str (:amount ethereum) " " (or (:token-symbol ethereum) "ETH")) | ||
| :divider? (or show-arbitrum? show-optimism?) | ||
| :theme theme}]) | ||
| (when show-optimism? | ||
| [network-amount | ||
| {:network :optimism | ||
| :amount (str optimism " OPT") | ||
| :amount (str (:amount optimism) " " (or (:token-symbol optimism) "OPT")) | ||
| :divider? show-arbitrum? | ||
| :theme theme}]) | ||
| (when show-arbitrum? | ||
| [network-amount | ||
| {:network :arbitrum | ||
| :amount (str arbitrum " ARB") | ||
| :amount (str (:amount arbitrum) " " (or (:token-symbol arbitrum) "ARB")) | ||
| :theme theme}])])) |
There was a problem hiding this comment.
There seems to be unnecessary duplication here. I think this can be a loop that includes the networks and which ones needs to be shown
There was a problem hiding this comment.
I totally agree @OmarBasem, we can definitely improve this component, but I think that is beyond the scope of this PR so I'll create an issue to keep track of this improvement!
There was a problem hiding this comment.
yep let's track this in a separate issue 👍
ulisesmac
force-pushed
the
16978-select-collectible
branch
from
0ca7668 to
5d8c349
Compare
briansztamfater
force-pushed
the
feat/send-collectible-events-4
branch
2 times, most recently
from
0efe7c4 to
eb3905e
Compare
58% of end-end tests have passedFailed tests (18)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (28)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
ulisesmac
reviewed
Jan 13, 2024
Comment on lines
+25
to
+28
| (rf/dispatch [:wallet/clean-scanned-address]) | ||
| (rf/dispatch [:wallet/clean-local-suggestions]) | ||
| (rf/dispatch [:wallet/clean-send-address]) | ||
| (rf/dispatch [:wallet/select-address-tab nil]) |
There was a problem hiding this comment.
Maybe we can create a single event and use the :fx key
This was referenced Jan 13, 2024
|
Hey @briansztamfater , I still haven't received the Goerli collectibles in my account. Since we don't have a reliable way to get collectibles on the Goerli testnet for now, I suggest merging both PRs: PR #18481 and PR #18473. We can retest the collectibles after implementing Issue #18510 or Issue #18507, where the collectibles use a more stable network to be send/received. Thank you for your work! |
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
feat/send-collectible-events-4
branch
from
d655588 to
4cc796a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16979 #18260
Summary
This PR adds basic events and UI to send a collectible from our wallet
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready