Dismiss keyboard when opening mute chat drawer #18486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (36)
|
| @@ -161,6 +161,7 @@ | |||
| :color cover-bg-color | |||
| :icon (if muted? :i/muted :i/activity-center) | |||
| :on-press (fn [] | |||
| (rf/dispatch [:dismiss-keyboard]) | |||
There was a problem hiding this comment.
Hi @ibrkhalil, Thank you very much for finding and fixing this issue.
Please can we add this :dismiss-keyboard to :show-bottom-sheet event itself?
There was a problem hiding this comment.
Thanks Parvesh
That's an excellent point, As the bottom sheet and the keyboard won't look nice together in any case.
src/status_im/navigation/events.cljs
Outdated
| @@ -119,6 +119,7 @@ | |||
| {:events [:show-bottom-sheet]} | |||
| [{:keys [db]} content] | |||
| (let [{:keys [sheets hide?]} (:bottom-sheet db)] | |||
| (rf/dispatch [:dismiss-keyboard]) | |||
| (rf/merge {:db (update-in db [:bottom-sheet :sheets] #(conj % content))} | |||
There was a problem hiding this comment.
Please add dispatch according to guideline
Parveshdhull
approved these changes
Jan 15, 2024
clauxx
reviewed
Jan 15, 2024
src/status_im/navigation/events.cljs
Outdated
| @@ -119,7 +119,8 @@ | |||
| {:events [:show-bottom-sheet]} | |||
| [{:keys [db]} content] | |||
| (let [{:keys [sheets hide?]} (:bottom-sheet db)] | |||
| (rf/merge {:db (update-in db [:bottom-sheet :sheets] #(conj % content))} | |||
| (rf/merge {:db (update-in db [:bottom-sheet :sheets] #(conj % content)) | |||
| :dispatch [:dismiss-keyboard]} | |||
There was a problem hiding this comment.
Will it always be the case that we'll want to hide the keyboard when showing the bottom sheet? My assumption is (also) yes, but wondering if there's places that would need the keyboard & bottom sheet together i.e. bottom sheet with an input.
There was a problem hiding this comment.
I think the behavior there should be to focus on the input of the bottom sheet once it's open
We're dismissing the keyboard that was there before rendering the bottom sheet.
clauxx
approved these changes
Jan 15, 2024
81% of end-end tests have passedFailed tests (7)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (39)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
Hi @ibrkhalil ! Can you please rebase your PR? |
|
Hi @ibrkhalil! I see such behaviour on Android and iOS and I assume it is an issue you was working on and it still present in this PR. Android: user can open mute chat drawer but keyboard is still opened (I assume it should be closed and then mute chat drawer opens) video_2024-02-02_14-49-47.mp4iOS: mute chat drawer is still overlapped by the keyboard IMG_6604.MP4Please check it on your side and let me know! |
85% of end-end tests have passedFailed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (41)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
|
|
Hi @ibrkhalil ! Thanks for your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18485
Summary
Dismisses the keyboard when mute chat drawer is opening.
status: ready