chore: upgrade kotlinPluginVersion to 1.9.0
#18487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
changed the title
kotlinPluginVersion to 1.9.0kotlinPluginVersion to 1.9.0
Jenkins BuildsClick to see older builds (12)
|
siddarthkay
force-pushed
the
upgrade-kotlin-plugin-version
branch
from
65c0f8f to
1e5112e
Compare
ibrkhalil
approved these changes
Jan 14, 2024
85% of end-end tests have passedFailed tests (4)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (41)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
|
jakubgs
approved these changes
Jan 15, 2024
Comment on lines
+53
to
+54
| org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 | ||
| org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin:1.9.0' \ |
There was a problem hiding this comment.
We need to stop this madness at some point...
siddarthkay
force-pushed
the
upgrade-kotlin-plugin-version
branch
from
1e5112e to
12def91
Compare
siddarthkay
force-pushed
the
upgrade-kotlin-plugin-version
branch
from
12def91 to
412fcfd
Compare
|
@siddarthkay thanks for the PR. tested and ready for merge. |
### Summary We need to bump `kotlin` Plugin version to `1.9.0` because the `nixpkgs` upgrade will set default `gradle` version to `8.4`. `gradle` version `8.4` comes with a base `kotlin` version of `1.9.0` which becomes incompatible with our existing version of `1.7` Otherwise we get errors like this : ``` e: /Users/siddarthkumar/code/experiments/status-mobile/node_modules/@react-native/ gradle-plugin/src/main/kotlin/com/facebook/react/utils/TaskUtils.kt: (25, 7): Class 'kotlin.collections.CollectionsKt__CollectionsKt' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.9.0, expected version is 1.7.1. The class is loaded from /nix/store/3a228ppiiljfvsrxyq15h25chmiwsmbh-gradle-8.4/lib/gradle/lib/ kotlin-stdlib-1.9.10.jar!/kotlin/collections/CollectionsKt__CollectionsKt.class e: /Users/siddarthkumar/code/experiments/status-mobile/node_modules/@react-native/gradle-plugin/ src/main/kotlin/com/facebook/react/utils/TaskUtils.kt: (25, 47): Class 'kotlin.collections.CollectionsKt___CollectionsKt' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.9.0, expected version is 1.7.1. The class is loaded from /nix/store/3a228ppiiljfvsrxyq15h25chmiwsmbh-gradle-8.4/lib/gradle/lib/ kotlin-stdlib-1.9.10.jar!/kotlin/collections/CollectionsKt___CollectionsKt.class e: /Users/siddarthkumar/code/experiments/status-mobile/node_modules/@react-native/gradle-plugin/ src/main/kotlin/com/facebook/react/utils/TaskUtils.kt: (27, 12): Class 'kotlin.collections.ArraysKt___ArraysKt' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.9.0, expected version is 1.7.1. The class is loaded from /nix/store/3a228ppiiljfvsrxyq15h25chmiwsmbh-gradle-8.4/lib/gradle/lib/ kotlin-stdlib-1.9.10.jar!/kotlin/collections/ArraysKt___ArraysKt.class ``` needed for #18321 In this commit we set `kotlinPluginVersion` to `1.9.0` and update `gradle` dependencies. #### Platforms - Android
siddarthkay
force-pushed
the
upgrade-kotlin-plugin-version
branch
from
412fcfd to
3f1057b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to bump
kotlinPlugin version to1.9.0because thenixpkgsupgrade will set defaultgradleversion to8.4.gradleversion8.4comes with a basekotlinversion of1.9.0which becomes incompatible with our existing version of1.7Otherwise we get errors like this :
needed for #18321
In this PR we set
kotlinPluginVersionto1.9.0and updategradledependencies.Platforms
Testing Notes
If E2E tests pass and CI is green then just a normal smoke test will do for this PR
status: ready