-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cannot add existing ENS owned by user #18567
Conversation
Jenkins BuildsClick to see older builds (12)
|
src/legacy/status_im/ens/core.cljs
Outdated
@@ -231,7 +231,7 @@ | |||
[db] | |||
(into #{} | |||
(remove #(= (:type %) :watch) | |||
(map #(eip55/address->checksum (:address %)) (get db :profile/wallet-accounts))))) | |||
(map #(eip55/address->checksum (:address (last %))) (get-in db [:wallet :accounts]))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Parveshdhull - The accounts are stored in a key-value (address-account) fashion inside :wallet :accounts
instead of storing as an array in :profile/wallet-accounts
.
(map #(eip55/address->checksum (:address (last %))) (get-in db [:wallet :accounts]))))) | |
(map #(eip55/address->checksum (:address %)) (vals (get-in db [:wallet :accounts])))))) |
11fc900
to
cae7021
Compare
69% of end-end tests have passed
Failed tests (12)Click to expandClass TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (33)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
|
cae7021
to
2d37da9
Compare
@Parveshdhull thank you foe the fix! Failed e2e are not PR related. Ready for merge. |
2d37da9
to
f05d8f4
Compare
fixes #18557
status: ready