Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: mute-icon when channel is muted #18580

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fixed: mute-icon when channel is muted #18580

merged 1 commit into from
Jan 23, 2024

Conversation

jo-mut
Copy link
Contributor

@jo-mut jo-mut commented Jan 21, 2024 •
edited
Loading

fixes #18222

This pr just creates the order in which these icons are displayed depending on the if-case

Before & After

@status-im-auto
Copy link
Member

status-im-auto commented Jan 21, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 15f99e3 #1 2024-01-21 23:15:01 ~5 min tests 📄log
✔️ 15f99e3 #1 2024-01-21 23:16:39 ~6 min ios 📱ipa 📲
✔️ 15f99e3 #1 2024-01-21 23:17:27 ~7 min android 🤖apk 📲
✔️ 15f99e3 #1 2024-01-21 23:17:35 ~7 min android-e2e 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 349aceb #2 2024-01-23 21:47:38 ~5 min tests 📄log
✔️ 349aceb #2 2024-01-23 21:48:42 ~7 min ios 📱ipa 📲
✔️ 349aceb #2 2024-01-23 21:50:40 ~9 min android-e2e 🤖apk 📲
✔️ 349aceb #2 2024-01-23 21:50:45 ~9 min android 🤖apk 📲
✔️ 9165aa0 #3 2024-01-23 23:20:14 ~5 min tests 📄log
✔️ 9165aa0 #3 2024-01-23 23:21:05 ~6 min ios 📱ipa 📲
✔️ 9165aa0 #3 2024-01-23 23:22:11 ~7 min android-e2e 🤖apk 📲
✔️ 9165aa0 #3 2024-01-23 23:22:14 ~7 min android 🤖apk 📲

@jo-mut jo-mut self-assigned this Jan 21, 2024
@jo-mut jo-mut marked this pull request as ready for review January 21, 2024 23:30
@status-im-auto
Copy link
Member

77% of end-end tests have passed

Total executed tests: 48
Failed tests: 8
Expected to fail tests: 3
Passed tests: 37

IDs of failed tests: 702732,703133,704613,703202,702947,702844,702775,702958 

IDs of expected to fail tests: 703503,702808,703629

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:276: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Device 2: Find Text by xpath: //*[@content-desc='pinned-messages-menu']//*[starts-with(@text,'Message 4')]/../../*[@content-desc='pinned-by']/android.widget.TextView
    Device 2: Text is user admin 

    critical/chats/test_group_chat.py:404: in test_group_chat_pin_messages
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message 1 is not pinned in group chat!
E    Pinned messages count 1 doesn't match expected 3 for user 2
E    Message 'Message 1' is missed on Pinned messages list for user 2
E    Message 'Message 3' is missed on Pinned messages list for user 2



    Device sessions

    2. test_group_chat_reactions, id: 703202

    Device 2: Looking for a message by text: This is a test message to check some reactions.
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_group_chat.py:109: in test_group_chat_reactions
    self.chats[1].set_reaction(message=message, emoji="thumbs-up")
../views/chat_view.py:1081: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:318: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Device 2: Tap on found: SendMessageButton
    # STEP: Checking unread indicators

    activity_center/test_activity_center.py:307: in test_activity_center_reply_read_unread_delete_filter_swipe
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(120)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 1: Getting preview message for link: #11707 

    critical/chats/test_public_chat_browsing.py:584: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    message.wait_for_element(60)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://github.com/status-im/status-mobile/pull/11707')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:63: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the url https://status.app/c/G8EAAGTiXKuwNbVVAu0GNLD-XzX4oz_E8oC1-7qSLikaTnCuG9Ag13ZgQKrMd8En9Qcpuaj3Qx3mfZ1atZzH8Zw-x_sFJ_MDv0P_7YfqoV-pNr3V4dsza-jVk41GaCGWasJb92Oer8qggaoNWf0tYCgSH19VonXciKPUz3ITdgke#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the url https://status.app/c/Ow==#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the url https://status.app/c#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the url https://status.app/c/ixiACjAKCHRlc3RDb21tEhZkemZ4Z2Nodmpra2xra2xrbCAgbGxsGAYiByM4OEIwRkYqARQD#zQ3shuK3RAMBGtNWJ5QAKtuGeyEhiwko5gXhyGg6T89Q2xrHq



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:101: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the deep link status-app://c/G8EAAGTiXKuwNbVVAu0GNLD-XzX4oz_E8oC1-7qSLikaTnCuG9Ag13ZgQKrMd8En9Qcpuaj3Qx3mfZ1atZzH8Zw-x_sFJ_MDv0P_7YfqoV-pNr3V4dsza-jVk41GaCGWasJb92Oer8qggaoNWf0tYCgSH19VonXciKPUz3ITdgke#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the deep link status-app://c/Ow==#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the deep link status-app://c#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the deep link status-app://c/ixiACjAKCHRlc3RDb21tEhZkemZ4Z2Nodmpra2xra2xrbCAgbGxsGAYiByM4OEIwRkYqARQD#zQ3shuK3RAMBGtNWJ5QAKtuGeyEhiwko5gXhyGg6T89Q2xrHq



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 2: Joining community
    Device 2: Looking for a message by text: https://status.app/c/ 

    activity_center/test_activity_center.py:469: in test_activity_center_admin_notification_accept_swipe
    self.community_2.join_community(open_community=False)
../views/chat_view.py:434: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1178: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 open community is not listed inside Pending communities tab
E    open community is not listed inside Joined communities tab

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (37)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    @mariia-skrypnyk mariia-skrypnyk self-assigned this Jan 22, 2024
    @status-im-auto
    Copy link
    Member

    75% of end-end tests have passed

    Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6

    IDs of failed tests: 702775,704613

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775

    Device 1: Find `BrowserTab` by `accessibility id`: `browser-stack-tab`
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:101: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the deep link status-app://c/G8EAAGTiXKuwNbVVAu0GNLD-XzX4oz_E8oC1-7qSLikaTnCuG9Ag13ZgQKrMd8En9Qcpuaj3Qx3mfZ1atZzH8Zw-x_sFJ_MDv0P_7YfqoV-pNr3V4dsza-jVk41GaCGWasJb92Oer8qggaoNWf0tYCgSH19VonXciKPUz3ITdgke#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the deep link status-app://c/Ow==#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the deep link status-app://c#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the deep link status-app://c/ixiACjAKCHRlc3RDb21tEhZkemZ4Z2Nodmpra2xra2xrbCAgbGxsGAYiByM4OEIwRkYqARQD#zQ3shuK3RAMBGtNWJ5QAKtuGeyEhiwko5gXhyGg6T89Q2xrHq



    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:63: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the url https://status.app/c/G8EAAGTiXKuwNbVVAu0GNLD-XzX4oz_E8oC1-7qSLikaTnCuG9Ag13ZgQKrMd8En9Qcpuaj3Qx3mfZ1atZzH8Zw-x_sFJ_MDv0P_7YfqoV-pNr3V4dsza-jVk41GaCGWasJb92Oer8qggaoNWf0tYCgSH19VonXciKPUz3ITdgke#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the url https://status.app/c/Ow==#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the url https://status.app/c#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK
E    Closed community was not requested to join by the url https://status.app/c/ixiACjAKCHRlc3RDb21tEhZkemZ4Z2Nodmpra2xra2xrbCAgbGxsGAYiByM4OEIwRkYqARQD#zQ3shuK3RAMBGtNWJ5QAKtuGeyEhiwko5gXhyGg6T89Q2xrHq



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_pin_messages, id: 702732
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @jo-mut !
    Thanks for your PR!
    I've checked mute-icon and it works as designed. Great job!
    Failed e2e are known and not related to the PR.
    Please, feel free to merge.

    @jo-mut jo-mut force-pushed the fix/channel-actions-mute-icon branch from 15f99e3 to 349aceb Compare January 23, 2024 21:41
    @jo-mut jo-mut force-pushed the fix/channel-actions-mute-icon branch from 349aceb to 9165aa0 Compare January 23, 2024 23:14
    @jo-mut jo-mut merged commit 3665fe2 into develop Jan 23, 2024
    6 checks passed
    @jo-mut jo-mut deleted the fix/channel-actions-mute-icon branch January 23, 2024 23:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @clauxx clauxx clauxx approved these changes

    @BalogunofAfrica BalogunofAfrica Awaiting requested review from BalogunofAfrica

    Assignees

    @jo-mut jo-mut

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Unmuted chat bell Icon not crossed out in opened chat
    5 participants
    @jo-mut @status-im-auto @mariia-skrypnyk @clauxx @mohsen-ghafouri