No ability to enter/paste assets exceeds the users's balance #18526 #18599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmilad75
requested review from
ilmotta,
briansztamfater,
OmarBasem and
J-Son89
and removed request for
ilmotta and
briansztamfater
Jenkins BuildsClick to see older builds (5)
|
J-Son89
reviewed
Jan 23, 2024
| [theme error] | ||
| (assoc text-input-dimensions | ||
| :color | ||
| (if error |
J-Son89
reviewed
Jan 23, 2024
| @@ -100,60 +100,4 @@ | |||
| (.then (fn [] | |||
| (h/is-truthy (h/get-by-label-text :button-one)) | |||
| (h/fire-event :press (h/get-by-label-text :button-one)) | |||
| (h/was-called on-confirm)))))) | |||
There was a problem hiding this comment.
why are we deleting all these tests? 🤔
There was a problem hiding this comment.
Because the tests were covering the input of more than limit which were reset to the limit. Now, when entering more than limit, nothing should happen except for changing the style.
J-Son89
reviewed
Jan 23, 2024
| (h/fire-event :press (h/query-by-label-text :keyboard-key-5)) | ||
| (h/wait-for #(h/get-by-text "$2850.00")))))) | ||
|
|
||
| (h/test "Try to fill more than limit" |
There was a problem hiding this comment.
this test should still work but the check should be updated 👍 .
we can technically fill more than limit no? 🤔
There was a problem hiding this comment.
The same thing here
J-Son89
reviewed
Jan 23, 2024
| (h/fire-event :press (h/query-by-label-text :keyboard-key-5)) | ||
| (h/wait-for #(h/get-by-text "$2850.00")))))) | ||
|
|
||
| (h/test "Switch from crypto to fiat and check limit" |
There was a problem hiding this comment.
this seems like a valid test case still
There was a problem hiding this comment.
Again, when the input was more than the limit and a switch was happening, the input was changing to the limit. Now, nothing should happen except for the style changing
J-Son89
reviewed
Jan 23, 2024
| @@ -61,6 +61,12 @@ | |||
| (>= (js/parseFloat balance) input-value))) | |||
| (map first))) | |||
|
|
|||
| (defn- reset-input-error | |||
| [new-value prev-value input-error] | |||
| (if (> new-value prev-value) | |||
There was a problem hiding this comment.
can be
(reset! input-error
(> new-value prev-value))
10% of end-end tests have passedFailed tests (42)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
|
79% of end-end tests have passedFailed tests (8)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (38)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
Hi @mmilad75 thank you for your work. No issues from my side. PR can be merged |
J-Son89
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18526
Screen.Recording.2024-01-23.at.20.07.16.mov