-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bottom tabs blur overlay color #18621
Conversation
Jenkins Builds
|
77% of end-end tests have passed
Failed tests (8)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (37)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
75% of end-end tests have passed
Failed tests (2)Click to expandClass TestDeepLinksOneDevice:
Passed tests (6)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
|
@Parveshdhull thanx for the PR. Failed e2e are not related. So in case there will be no changes after review - it ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Parveshdhull
Thanks for solving this issue.
The problem is bottom-tabs-blur-overlay
(the style fn) is being used in the reanimated/blur-view
, and currently, inline styles using a vector is only supported in reanimated/view
.
I could add support for vector styles to other components later. In the meantime, this PR is ready to get merged!
Thanks again!
70f2900
to
84bc730
Compare
related to https://discord.com/channels/1103692771585433630/1103692773363810317/1199894835797172274
It looks like inline reanimated styles are breaking blur view. I am reverting the use for this case.
(Please feel free to close PR if you find cause or another solution)
status: ready