Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile image & customization color for share-qr-code #18643

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Fix profile image & customization color for share-qr-code #18643

merged 2 commits into from
Jan 29, 2024

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Jan 26, 2024

fixes #18639

Summary

Fixed the qr code not being visible due to customization-color being nil in :profile/profile -> using specific selector with default value instead. Also, the profile-picture wasn't visible and not present in :profile/profile at all. Found another selector for that as well -> :profile/profile-with-image.

Review notes

Testing notes

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Share qr code

Steps to test

  • Repeat steps from the original issue

Before and after screenshots comparison

status: ready

@clauxx clauxx self-assigned this Jan 26, 2024
@clauxx clauxx requested a review from J-Son89 January 26, 2024 14:03
@clauxx clauxx changed the title fix: profile image & customization color for share-qr-code Fix profile image & customization color for share-qr-code Jan 26, 2024
@clauxx
Copy link
Member Author

clauxx commented Jan 26, 2024 •
edited
Loading

@status-im/mobile-qa I wonder about the blue box before the user's name. Is that supposed to be empty or it should have the profile picture as well? I checked with an account that wasn't synced and it was the same.

@status-im-auto
Copy link
Member

status-im-auto commented Jan 26, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d85976d #1 2024-01-26 14:09:20 ~5 min ios 📱ipa 📲
✔️ d85976d #1 2024-01-26 14:09:35 ~6 min tests 📄log
✔️ d85976d #1 2024-01-26 14:12:53 ~9 min android 🤖apk 📲
✔️ d85976d #1 2024-01-26 14:12:58 ~9 min android-e2e 🤖apk 📲
✔️ 2e7f945 #2 2024-01-29 11:58:52 ~5 min tests 📄log
✔️ 2e7f945 #2 2024-01-29 11:59:32 ~5 min ios 📱ipa 📲
✔️ 2e7f945 #2 2024-01-29 12:02:33 ~8 min android-e2e 🤖apk 📲
✔️ 2e7f945 #2 2024-01-29 12:02:39 ~8 min android 🤖apk 📲

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 48
Failed tests: 0
Expected to fail tests: 4
Passed tests: 44

IDs of expected to fail tests: 702783,703503,702808,703629

Expected to fail tests (4)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808

Device 3: Looking for a message by text: message from old member
Device 3: Looking for a message by text: message from new member 

critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

[[Data delivery issue]]

Device sessions

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

# STEP: Device 2 checks that he's joined the community
Device 2: Find BaseElement by accessibility id: toast-content 

critical/chats/test_public_chat_browsing.py:1161: in test_community_join_when_node_owner_offline
    cur_text = self.community_2.toast_content_element.text
../views/base_element.py:229: in text
    return self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by accessibility id: `toast-content` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

[[Can't join a community if admin goes offline, https://github.com//issues/17678]]

Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503 

Test is not run, e2e blocker

[[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Delivered 

critical/chats/test_1_1_public_chats.py:610: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline

[[Data delivery issue]]

Device sessions

Passed tests (44)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions

2. test_group_chat_mute_chat, id: 703495
Device sessions

3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions

4. test_group_chat_reactions, id: 703202
Device sessions

5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions

3. test_1_1_chat_push_emoji, id: 702813
Device sessions

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

5. test_1_1_chat_edit_message, id: 702855
Device sessions

6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions

7. test_1_1_chat_pin_messages, id: 702731
Device sessions

8. test_1_1_chat_message_reaction, id: 702730
Device sessions

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

3. test_community_undo_delete_message, id: 702869
Device sessions

4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions

5. test_community_mute_community_and_channel, id: 703382
Device sessions

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions

2. test_community_one_image_send_reply, id: 702859
Device sessions

3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions

4. test_community_mark_all_messages_as_read, id: 703086
Device sessions

5. test_community_contact_block_unblock_offline, id: 702894
Device sessions

6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions

7. test_community_message_delete, id: 702839
Device sessions

8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions

9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions

10. test_community_message_edit, id: 702843
Device sessions

11. test_community_unread_messages_badge, id: 702841
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions

2. test_1_1_chat_mute_chat, id: 703496
Device sessions

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions

2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions

2. test_links_deep_links, id: 702775
Device sessions

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions

2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions

3. test_community_mentions_push_notification, id: 702786
Device sessions

4. test_community_leave, id: 702845
Device sessions

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions

2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions

3. test_activity_center_contact_request_decline, id: 702850
Device sessions

@pavloburykh pavloburykh mentioned this pull request Jan 27, 2024
Closed
@pavloburykh pavloburykh self-assigned this Jan 29, 2024
@pavloburykh
Copy link
Contributor

@clauxx thank you for the quick fix of this issue. Tested and ready for merge.

I wonder about the blue box before the user's name.

Thanks for pointing out. This is a known issue. Will be logged and fixed in separate PR.

@clauxx clauxx merged commit ab509da into develop Jan 29, 2024
6 checks passed
@clauxx clauxx deleted the cl-18639-fix-share-qr-code branch January 29, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@J-Son89 J-Son89 J-Son89 approved these changes

@mmilad75 mmilad75 Awaiting requested review from mmilad75

Assignees

@clauxx clauxx

@pavloburykh pavloburykh

Labels
request-manual-qa Tested - OK
Projects
Pipeline for QA
Archived in project
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken profile QR after syncing with desktop
5 participants
@clauxx @status-im-auto @pavloburykh @cammellos @J-Son89