-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty state illustration image for pinned messages #18660
Conversation
Jenkins BuildsClick to see older builds (24)
|
93d7dbc
to
aed752a
Compare
:dark (js/require "../resources/images/ui2/sweating-man-dark.png")}}) | ||
:dark (js/require "../resources/images/ui2/sweating-man-dark.png")} | ||
:no-pinned-messages | ||
{:light (js/require "../resources/images/ui2/no-pinned-messages-light.png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -2,9 +2,11 @@ | |||
(:require | |||
[quo.core :as quo] | |||
[quo.foundations.colors :as colors] | |||
[quo.theme :as quo.theme] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[quo.theme]
|
||
(defn- internal-pinned-messages | ||
[params] | ||
[:f> f-pinned-messages params]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't need to make this a functional component to work with with-theme
wrapper btw - the with-theme method should handle this already 🤔
aed752a
to
5bb5fd4
Compare
79% of end-end tests have passed
Failed tests (8)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (38)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
5bb5fd4
to
3dc704b
Compare
3dc704b
to
c80c4b5
Compare
40% of end-end tests have passed
Failed tests (28)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (19)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
|
c80c4b5
to
608b8a7
Compare
88% of end-end tests have passed
Failed tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (42)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
Hi @jo-mut ! I am wondering if this empty state should contain "Just keep pinning" text and the part with community name and channel that I've marked here: |
@mariia-skrypnyk good question. Now that you asked this I think design @pedro-et can clarify. For community channels i based on this figma https://www.figma.com/file/PPWkgOYlZZDxZv5SDGsZVV/Posts-%26-Attachments-for-Mobile?type=design&node-id=3513%3A380099&mode=design&t=PrimwZf6ymyE15om-1 and for messages i just left it was it was before as i did not find the scenario that is specific to the pinned messages of 1-1 chats I wonder if there is something am missing? |
Asked the design team. |
@jo-mut I am going to move it for @Francesca-G review for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✨
608b8a7
to
b07889a
Compare
fixes #17522
Summary
Pr add empty state to pinned messages in channel and chat
Light Theme & Dark Theme