Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐰 Fix #18375 - Disappearing tabs when sending assets #18662

Merged
merged 1 commit into from
Jan 30, 2024
Merged

🐰 Fix #18375 - Disappearing tabs when sending assets #18662

merged 1 commit into from
Jan 30, 2024

Conversation

shivekkhurana
Copy link
Contributor

@shivekkhurana shivekkhurana commented Jan 29, 2024 •
edited
Loading

Fixes #18375

Summary

Remove the option to scroll on click, when selecting an address from various sources.
Having the scroll-on-click turned on breaks the UI (as outlined in #18375).

I have not been able to find the exact cause of this, but it feels related to having nested scroll views. The issue occurs in flat-list component which is outside the scope of our app (have highlighted the error on the issue page)

With this fix in place, the UX takes a tiny hit, but the functionality remains intact. So far, the functionality was breaking down.

Platforms

  • Android
  • iOS
Functional
  • wallet / transactions

Steps to test

  1. Goto wallet tab
  2. Select an account
  3. Click "Send"
  4. Chose any tab for address source except for first one (any except ''Recent")
  5. Press the address input
  6. Make sure software keyboard pulls up
  7. Now press on the empty screen to trigger on-blur event on input
  8. You should be brought back to send page you started with
  9. All tabs should be visible

With the bug, some tabs disappeared.

status: ready

@shivekkhurana shivekkhurana linked an issue Jan 29, 2024 that may be closed by this pull request
Wallet - ui bug - Send Flow - select account tabs jumping after closing address input #18375
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Jan 29, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f5ef293 #1 2024-01-29 12:40:54 ~1 min tests 📄log
✔️ f5ef293 #1 2024-01-29 12:45:06 ~6 min ios 📱ipa 📲
✔️ f5ef293 #1 2024-01-29 12:47:12 ~8 min android-e2e 🤖apk 📲
✔️ f5ef293 #1 2024-01-29 12:47:16 ~8 min android 🤖apk 📲
❌ 5c4979d #2 2024-01-29 12:55:34 ~1 min tests 📄log
✔️ 5c4979d #2 2024-01-29 12:59:50 ~6 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 199edac #4 2024-01-29 13:03:45 ~1 min tests 📄log
✔️ 199edac #4 2024-01-29 13:08:56 ~6 min ios 📱ipa 📲
✔️ 199edac #4 2024-01-29 13:09:46 ~7 min android-e2e 🤖apk 📲
✔️ 199edac #4 2024-01-29 13:10:00 ~8 min android 🤖apk 📲
✔️ 4ba25c0 #5 2024-01-30 08:27:47 ~5 min tests 📄log
✔️ 4ba25c0 #5 2024-01-30 08:28:14 ~5 min ios 📱ipa 📲
✔️ 4ba25c0 #5 2024-01-30 08:29:28 ~6 min android-e2e 🤖apk 📲
✔️ 4ba25c0 #5 2024-01-30 08:30:23 ~7 min android 🤖apk 📲

@shivekkhurana shivekkhurana force-pushed the 18375-wallet-ui-bug-send-flow-select-account-tabs-jumping-after-closing-address-input branch 3 times, most recently from 61f91f7 to 199edac Compare January 29, 2024 13:01
@shivekkhurana shivekkhurana self-assigned this Jan 29, 2024
@shivekkhurana shivekkhurana requested a review from a team January 29, 2024 13:06
@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 2
Passed tests: 44

IDs of failed tests: 704613,702775 

IDs of expected to fail tests: 703503,703629

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Looking for a message by text: https://status.app/c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK
    Device 1: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK')]` 

    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the url https://status.app/c/G00AAGS9TbI9mSR-ZNmFrhRjNuEeXAAbcAIUaLLJyjMOG3ACJQ12oIHD78QhzO9s_T5bUeU7rnATWJg3mGgTUemrAg==#zQ3shspPKCZ1VPVQ9dLXGufUGvGphjxVwrcZ6rkZc7S39T4b3
E    Closed community was not requested to join by the url https://status.app/c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the deep link status.app://c/G00AAGS9TbI9mSR-ZNmFrhRjNuEeXAAbcAIUaLLJyjMOG3ACJQ12oIHD78QhzO9s_T5bUeU7rnATWJg3mGgTUemrAg==#zQ3shspPKCZ1VPVQ9dLXGufUGvGphjxVwrcZ6rkZc7S39T4b3
E    Closed community was not requested to join by the deep link status.app://c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1177: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 open community is not listed inside Pending communities tab
E    Joined status is not displayed
E    open community is not listed inside Joined communities tab

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Device sessions

    Passed tests (44)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @shivekkhurana
    🎡 Don't scroll on press
    4ba25c0 
    - Hack fix
- Scroll on press breaks something with FlatList
- Which causes some items to not render
- Could be related to scroll view inside scroll view
- But fixing this bug by compromising the UX a tiny bit
    @shivekkhurana shivekkhurana force-pushed the 18375-wallet-ui-bug-send-flow-select-account-tabs-jumping-after-closing-address-input branch from 199edac to 4ba25c0 Compare January 30, 2024 08:22
    @shivekkhurana shivekkhurana merged commit 0349b0e into develop Jan 30, 2024
    6 checks passed
    @shivekkhurana shivekkhurana deleted the 18375-wallet-ui-bug-send-flow-select-account-tabs-jumping-after-closing-address-input branch January 30, 2024 08:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    Assignees

    @shivekkhurana shivekkhurana

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Wallet - ui bug - Send Flow - select account tabs jumping after closing address input
    5 participants
    @shivekkhurana @status-im-auto @briansztamfater @smohamedjavid @J-Son89