Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test networks short-name->id #18692

Merged
merged 5 commits into from
Feb 5, 2024
Merged

fix: test networks short-name->id #18692

merged 5 commits into from
Feb 5, 2024

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Feb 1, 2024 •
edited
Loading

fixes: #18693

This PR fixes the function short-name->id to work for test networks also.

@OmarBasem OmarBasem self-assigned this Feb 1, 2024
@OmarBasem OmarBasem changed the title fix: test net networks fix: test networks short-name->id Feb 1, 2024
@OmarBasem OmarBasem requested a review from a team February 1, 2024 09:56
@status-im-auto
Copy link
Member

status-im-auto commented Feb 1, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c7703e5 #1 2024-02-01 10:01:58 ~5 min tests 📄log
✔️ c7703e5 #1 2024-02-01 10:03:34 ~7 min android 🤖apk 📲
✔️ c7703e5 #1 2024-02-01 10:03:35 ~7 min ios 📱ipa 📲
✔️ c7703e5 #1 2024-02-01 10:04:24 ~8 min android-e2e 🤖apk 📲
✔️ 4e4121e #2 2024-02-05 04:33:24 ~5 min tests 📄log
✔️ 4e4121e #2 2024-02-05 04:34:28 ~6 min android-e2e 🤖apk 📲
✔️ 4e4121e #2 2024-02-05 04:35:33 ~8 min ios 📱ipa 📲
✔️ 4e4121e #2 2024-02-05 04:36:31 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8079063 #3 2024-02-05 04:46:49 ~2 min tests 📄log
✔️ 196e1df #4 2024-02-05 04:53:53 ~6 min ios 📱ipa 📲
✔️ 196e1df #4 2024-02-05 04:54:29 ~7 min android-e2e 🤖apk 📲
✔️ 196e1df #4 2024-02-05 04:54:39 ~7 min android 🤖apk 📲
✔️ 196e1df #5 2024-02-05 05:13:42 ~5 min tests 📄log

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Expected to fail tests: 2
Passed tests: 43

IDs of failed tests: 704613,704615,702775 

IDs of expected to fail tests: 703503,703629

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: text after edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:796: in test_community_edit_delete_message_when_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Updated message 'text after edit' is not delivered to the receiver



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK')] 

    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the url https://status.app/c/G00AAGS9TbI9mSR-ZNmFrhRjNuEeXAAbcAIUaLLJyjMOG3ACJQ12oIHD78QhzO9s_T5bUeU7rnATWJg3mGgTUemrAg==#zQ3shspPKCZ1VPVQ9dLXGufUGvGphjxVwrcZ6rkZc7S39T4b3
E    Closed community was not requested to join by the url https://status.app/c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the deep link status.app://c/G00AAGS9TbI9mSR-ZNmFrhRjNuEeXAAbcAIUaLLJyjMOG3ACJQ12oIHD78QhzO9s_T5bUeU7rnATWJg3mGgTUemrAg==#zQ3shspPKCZ1VPVQ9dLXGufUGvGphjxVwrcZ6rkZc7S39T4b3
E    Closed community was not requested to join by the deep link status.app://c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shgkDFQEnwxji7CvMTokMrShmC2UgxiJ549X5Aw746zQrK



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1177: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 open community is not listed inside Pending communities tab
E    Joined status is not displayed
E    open community is not listed inside Joined communities tab

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (43)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @OmarBasem OmarBasem force-pushed the wallet/fix-networks-testnet branch from 4e4121e to 8079063 Compare February 5, 2024 04:44
    @OmarBasem OmarBasem merged commit a6565b5 into develop Feb 5, 2024
    6 checks passed
    @OmarBasem OmarBasem deleted the wallet/fix-networks-testnet branch February 5, 2024 05:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @vkjr vkjr Awaiting requested review from vkjr

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    short-name->id function for test networks
    3 participants
    @OmarBasem @status-im-auto @smohamedjavid