[Fix] Wallet - Clear input on long press delete #18732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohamedjavid
requested review from
briansztamfater,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
J-Son89
reviewed
Feb 6, 2024
| @@ -15,7 +15,7 @@ | |||
| (defn- view-internal | |||
| [] | |||
| (let [pressed? (reagent/atom false)] | |||
There was a problem hiding this comment.
should we add a schema to this component while we are adding new props to it?
I think it's not in the list of components in the schema epic as I probably missed this ns when making those issues
There was a problem hiding this comment.
@J-Son89 - Can we do it in a separate PR/issue? To find and fix bugs related to those changes (if any).
Jenkins BuildsClick to see older builds (16)
|
Comment on lines
+27
to
+29
| :on-long-press (fn [] | ||
| (when (fn? on-long-press) | ||
| (on-long-press label))) |
There was a problem hiding this comment.
Maybe just
#(when (fn? on-long-press)
(on-long-press label))
There was a problem hiding this comment.
@briansztamfater
Previously I'd suggest the same, but some time ago @ilmotta suggested to only use # for simple one-liner functions.
The reason is it takes longer for the reader to realize if %, (or %1, %2, etc...) is being used and where is placed. Instead if we have (fn[]) we know what the function takes.
briansztamfater
approved these changes
Feb 6, 2024
OmarBasem
approved these changes
Feb 6, 2024
ulisesmac
approved these changes
Feb 6, 2024
Comment on lines
+128
to
+163
| on-long-press-delete (fn [loading-routes?] | ||
| (when-not loading-routes? | ||
| (reset! input-value "") | ||
| (reset! input-error false) | ||
| (move-input-cursor input-selection 0) | ||
| (reagent/flush))) |
Comment on lines
+27
to
+29
| :on-long-press (fn [] | ||
| (when (fn? on-long-press) | ||
| (on-long-press label))) |
There was a problem hiding this comment.
@briansztamfater
Previously I'd suggest the same, but some time ago @ilmotta suggested to only use # for simple one-liner functions.
The reason is it takes longer for the reader to realize if %, (or %1, %2, etc...) is being used and where is placed. Instead if we have (fn[]) we know what the function takes.
smohamedjavid
force-pushed
the
fix/wallet-clear-input-on-long-press-delete
branch
from
0818e7e to
3ccc1db
Compare
42% of end-end tests have passedFailed tests (27)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (20)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
31% of end-end tests have passedFailed tests (32)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (15)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
pavloburykh
force-pushed
the
fix/wallet-clear-input-on-long-press-delete
branch
from
3ccc1db to
26a67ac
Compare
|
Hi @smohamedjavid ! ISSUE 1 All elements on the screen looks like inactive "Send assets" screen Steps: Go to Wallet -> Send Actual result: Expected result: Additional info: Android 13.0 The rebase took place today and after analysis of today's merges we didn't find the strong reason :( |
smohamedjavid
force-pushed
the
fix/wallet-clear-input-on-long-press-delete
branch
from
26a67ac to
b0812cd
Compare
|
Hi @smohamedjavid ! |
|
Hi @mariia-skrypnyk! |
pavloburykh
force-pushed
the
fix/wallet-clear-input-on-long-press-delete
branch
from
b0812cd to
91af901
Compare
83% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (40)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
@smohamedjavid Thanks for your fix! I've checked clear input on long press and faded effect on Android. |
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
fix/wallet-clear-input-on-long-press-delete
branch
from
91af901 to
2328d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18685
Summary
This PR allows clearing the amount input (in the send flow) by long-pressing the delete key.
Clear.input.mp4
Platforms
Steps to test
Sendstatus: ready