-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: upgrade from 2.13.4 to 2.19.3 #18742
Conversation
Jenkins BuildsClick to see older builds (41)
|
These warning are kinda annoying but not serious:
It is a known issue: |
f4006cb
to
0543485
Compare
Another bigger problem is this error:
Which has not been resolved since EDIT: The correct solution is to move |
0543485
to
23c2efd
Compare
All CI hosts have been upgraded to use Nix
I did not use |
23c2efd
to
8a5c518
Compare
8a5c518
to
6d19967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Glad that we are able to bump the nix interpreter version ❤️👏🏻👏🏻
Testing locally with make nix-purge
(just to be 100% sure) and will reply back after checking a couple of make
commands.
d46a775
to
37aa6ad
Compare
There is an issue that happens on some hosts:
But this happens only when the SSH process for |
37aa6ad
to
b6cc389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think make clean
should run git clean
without -x
. Removing only not ignored files. And purge should remove both ignored and not (-X
as it it is now).
Might not be related to the issue. I was just thinking if there are any cases on CI or locally, when .nix-gcroots
is removed, but should not.
b6cc389
to
0620365
Compare
@yakimant your point about relationship between I think there is a possibility that calling |
We are moving location of symlinks for build derivations for `gcroots` from `/nix/var/nix/gcroots/per-user` to `.nix-gcroots` in the repo to avoid errors like this caused by profile migration in `2.14` release: ``` error: creating directory '/nix/var/nix/gcroots/per-user/joe': Permission denied ``` For more details see: NixOS/nix#8564 To upgrade without using `make nix-purge` use `make nix-upgrade`. Related infra change: status-im/infra-ci@37c6ce47 Signed-off-by: Jakub Sokołowski <jakub@status.im>
0620365
to
c5df51d
Compare
We are moving location of symlinks for build derivations for
gcroots
from/nix/var/nix/gcroots/per-user
to.nix-gcroots
in the repo to avoid errors like this caused by profile migration in2.14
release:For more details see: NixOS/nix#8564
To upgrade without using
make nix-purge
usemake nix-upgrade
.Related infra change:
infra-ci#37c6ce47
- nix-setup: upgrade from 2.14.1 to 2.19.2