Account permissions component malli schema fix #18770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayesivan
commented
Feb 9, 2024
| @@ -12,7 +12,7 @@ | |||
| [:address [:maybe :string]] | |||
| [:emoji [:maybe :string]] | |||
| [:customization-color {:optional true} [:maybe :schema.common/customization-color]]]] | |||
| [:token-details {:optional true} [:maybe [:vector required-tokens/?schema]]] | |||
| [:token-details {:optional true} [:maybe [:sequential required-tokens/?schema]]] | |||
There was a problem hiding this comment.
As pointed out by @ilmotta here, using :vector will fail when lazy sequences are passed. @mmilad75, I noticed you reverted it back to :vector. Could you please clarify if there's a specific reason for this choice?
@ilmotta, perhaps we could consider adding this information to the malli guideline section.
There was a problem hiding this comment.
This has been brought up earlier too. :sequential is the way to go.
shivekkhurana
approved these changes
Feb 9, 2024
| @@ -12,7 +12,7 @@ | |||
| [:address [:maybe :string]] | |||
| [:emoji [:maybe :string]] | |||
| [:customization-color {:optional true} [:maybe :schema.common/customization-color]]]] | |||
| [:token-details {:optional true} [:maybe [:vector required-tokens/?schema]]] | |||
| [:token-details {:optional true} [:maybe [:sequential required-tokens/?schema]]] | |||
There was a problem hiding this comment.
This has been brought up earlier too. :sequential is the way to go.
21% of end-end tests have passedFailed tests (37)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (10)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small fix to the account permissions component schema.
No QA is needed.
status: ready