Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Broken wallet account emoji when syncing devices #18828

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[Fix] Broken wallet account emoji when syncing devices #18828

merged 1 commit into from
Feb 15, 2024

Conversation

smohamedjavid
Copy link
Member

fixes #18640

Summary

This PR fixes the broken wallet account emoji when syncing devices by adding a sanitization method for the wallet account emoji. The desktop can handle both variants (raw emoji and img tag) and this PR adds the same for mobile.

Review notes

Since the Desktop uses Twemoji, it is used to save the account emoji in img tag in status-go. It was fixed to save only the emoji instead of img tag. Somehow, the img tag is still propagated from the desktop. It will be debugged by the desktop team later (as this issue is not a priority at this moment). Additionally, this fix (sanitization) would help prevent such issues from happening from backup restore in mobile.

Platforms

  • Android
  • iOS

Steps to test

Prerequisite: Create a user in Desktop

  • Open Status
  • Sync the mobile app with the Desktop for the newly created user
  • Verify the account emojis displayed across the application are not broken (or displaying an HTML img tag)

status: ready

@smohamedjavid smohamedjavid self-assigned this Feb 14, 2024
J-Son89
J-Son89 reviewed Feb 14, 2024
View reviewed changes
src/status_im/contexts/wallet/data_store.cljs
@@ -22,6 +22,12 @@
[account]
(assoc account :watch-only? (= (:type account) :watch)))

(defn- sanitize-emoji
[emoji]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a comment to the purpose of this

@status-im-auto
Copy link
Member

status-im-auto commented Feb 14, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6c47bb1 #1 2024-02-14 19:46:02 ~6 min tests 📄log
✔️ 6c47bb1 #1 2024-02-14 19:47:24 ~8 min ios 📱ipa 📲
✔️ 6c47bb1 #1 2024-02-14 19:48:34 ~9 min android-e2e 🤖apk 📲
✔️ 6c47bb1 #1 2024-02-14 19:48:38 ~9 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 181cf09 #2 2024-02-14 20:32:58 ~6 min tests 📄log
✔️ 181cf09 #2 2024-02-14 20:33:28 ~6 min ios 📱ipa 📲
✔️ 181cf09 #2 2024-02-14 20:35:40 ~8 min android 🤖apk 📲
✔️ 181cf09 #2 2024-02-14 20:35:40 ~8 min android-e2e 🤖apk 📲
✔️ 3cd4ae1 #3 2024-02-15 13:20:15 ~5 min tests 📄log
✔️ 3cd4ae1 #3 2024-02-15 13:21:29 ~6 min ios 📱ipa 📲
✔️ 3cd4ae1 #3 2024-02-15 13:22:02 ~7 min android-e2e 🤖apk 📲
✔️ 3cd4ae1 #3 2024-02-15 13:22:09 ~7 min android 🤖apk 📲

@smohamedjavid smohamedjavid force-pushed the fix/account-emoji-on-syncing branch from 6c47bb1 to 181cf09 Compare February 14, 2024 20:26
@VolodLytvynenko VolodLytvynenko self-assigned this Feb 15, 2024
@status-im-auto
Copy link
Member

48% of end-end tests have passed

Total executed tests: 48
Failed tests: 24
Expected to fail tests: 1
Passed tests: 23

IDs of failed tests: 702894,703086,702855,702730,702958,702786,702731,703202,702841,702839,702733,702808,702809,702838,704615,702948,702859,702957,702783,702843,702782,702850,702732,703194 

IDs of expected to fail tests: 703503

Failed tests (24)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855

    Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:381: in test_1_1_chat_edit_message
    self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:243: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sending



    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730

    Device 2: Wait for text element EmojisNumber to be equal to 1
    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2] 

    critical/chats/test_1_1_public_chats.py:64: in test_1_1_chat_message_reaction
    message_receiver.emojis_below_message(emoji="thumbs-up").wait_for_element_text(1, 90)
../views/base_element.py:173: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: EmojisNumber by xpath: `//*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView
    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:195: in test_1_1_chat_pin_messages
    chat.pinned_messages_count.wait_for_element_text(text="2",
../views/base_element.py:182: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Pinned messages count is not 2 as expected!



    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:470: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:243: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sending



    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 2: Find OpenInStatusButton by xpath: //*[@text="Open in Status"]
    Device 2: Tap on found: OpenInStatusButton 

    critical/chats/test_1_1_public_chats.py:178: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No reply received in 1-1 chat



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/chats/test_public_chat_browsing.py:927: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Edited message is not shown correctly for the (receiver) admin
E    Push notification with the mention was not received by the invited member



    Device sessions

    2. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:979: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    bold text in underscores is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    italic text in asteric is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    italic text in underscore is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    inline code is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    quote reply (one row) is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    bold text in asterics is not displayed with markdown in 1-1 chat for the recipient (device 2) 
E   
E    bold text in underscores is not displayed with markdown in 1-1 chat for the recipient (device 2) 
E   
E    italic text in underscore is not displayed with markdown in 1-1 chat for the recipient (device 2) 
E   
E    inline code is not displayed with markdown in 1-1 chat for the recipient (device 2) 
E   
E    code blocks is not displayed with markdown in 1-1 chat for the recipient (device 2)



    Device sessions

    3. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: #cats 

    critical/chats/test_public_chat_browsing.py:1062: in test_community_hashtag_links_to_community_channels
    self.channel_2.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    2. test_activity_center_mentions, id: 702957

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Wait for text element EmojisNumber to be equal to 1
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2] 

    critical/chats/test_group_chat.py:121: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="laugh").wait_for_element_text(1)
../views/base_element.py:173: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EmojisNumber by xpath: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 message from old member if not shown for device 2



    Device sessions

    3. test_group_chat_pin_messages, id: 702732

    Device 2: Find Text by xpath: //*[@content-desc='pinned-messages-menu']//*[starts-with(@text,'Message 4')]/../../*[@content-desc='pinned-by']/android.widget.TextView
    Device 2: Text is user admin 

    critical/chats/test_group_chat.py:404: in test_group_chat_pin_messages
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message 1 is not pinned in group chat!
E    Message 2 is not pinned in group chat!
E    Pinned messages count 2 doesn't match expected 3 for user 2
E    Message 'Message 1' is missed on Pinned messages list for user 2



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 1: Tap on found: Button
    Device 1: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    activity_center/test_activity_center.py:69: in test_activity_center_contact_request_decline
    if self.home_1.pending_contact_request_text.text != '1':
../views/base_element.py:407: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:612: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find UnblockContactButton by accessibility id: Unblock-item-button
    Device 1: Find UnblockContactButton by accessibility id: Unblock-item-button 

    critical/chats/test_public_chat_browsing.py:692: in test_community_contact_block_unblock_offline
    self.chat_1.unblock_contact_button.click()
../views/chat_view.py:70: in click
    self.scroll_to_element()
../views/base_element.py:197: in scroll_to_element
    raise NoSuchElementException(
 Device 1: UnblockContactButton by accessibility id: `Unblock-item-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until Text by accessibility id: community-description-text will be presented 

    critical/chats/test_public_chat_browsing.py:766: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    3. test_community_unread_messages_badge, id: 702841

    # STEP: Check new messages badge is shown for community
    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented 

    critical/chats/test_public_chat_browsing.py:634: in test_community_unread_messages_badge
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New message community badge is not shown
E    New messages channel badge is not shown on channel



    Device sessions

    4. test_community_message_delete, id: 702839

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: delete for me 

    critical/chats/test_public_chat_browsing.py:376: in test_community_message_delete
    self.channel_1.chat_element_by_text(message_to_delete_for_me).wait_for_element(120)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'delete for me')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'new message' is under today
    Device 2: Looking for a message by text: new message 

    critical/chats/test_public_chat_browsing.py:339: in test_community_message_send_check_timestamps_sender_username
    self.channel_2.verify_message_is_under_today_text(new_message, self.errors, 60)
../views/chat_view.py:1004: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element(timeout)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615

    # STEP: Receiver is checking if initial messages were delivered
    Device 1: Looking for a message by text: message to edit 

    critical/chats/test_public_chat_browsing.py:781: in test_community_edit_delete_message_when_offline
    self.channel_1.driver.fail("Message '%s' was not received")
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Message '%s' was not received



    Device sessions

    7. test_community_one_image_send_reply, id: 702859

    Device 2: Looking for a message by text: description
    Device 2: Looking for a message by text: description 

    critical/chats/test_public_chat_browsing.py:439: in test_community_one_image_send_reply
    self.channel_2.chat_element_by_text(image_description).wait_for_visibility_of_element(10)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    8. test_community_message_edit, id: 702843

    Device 2: Looking for a message by text: Message AFTER edit 2 (Edited)
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_public_chat_browsing.py:353: in test_community_message_edit
    self.channel_2.set_reaction(message_text_after_edit)
../views/chat_view.py:1084: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:318: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    9. test_community_several_images_send_reply, id: 703194

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: gallery 

    critical/chats/test_public_chat_browsing.py:428: in test_community_several_images_send_reply
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Gallery message was not received



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (23)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @smohamedjavid, thank you for PR. No issues from my side. PR is ready to be merged

    @smohamedjavid
    [Fix] Broken wallet account emoji when syncing devices
    3cd4ae1 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid smohamedjavid force-pushed the fix/account-emoji-on-syncing branch from 181cf09 to 3cd4ae1 Compare February 15, 2024 13:14
    @smohamedjavid smohamedjavid merged commit 10f9fe1 into develop Feb 15, 2024
    6 checks passed
    @smohamedjavid smohamedjavid deleted the fix/account-emoji-on-syncing branch February 15, 2024 13:23
    ilmotta pushed a commit that referenced this pull request Feb 15, 2024
    @smohamedjavid @ilmotta
    [Fix] Broken wallet account emoji when syncing devices (#18828)
    7aa62c5 
    This commit fixes the broken wallet account emoji when syncing devices by adding a sanitization method for the wallet account emoji. The desktop can handle both variants (raw emoji and img tag); this PR adds the same for mobile.

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @smohamedjavid smohamedjavid

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Broken wallet icon after sync with desktop
    6 participants
    @smohamedjavid @status-im-auto @VolodLytvynenko @shivekkhurana @J-Son89 @pavloburykh