disable hermes via gradle flag and other cleanup in build script of Android
#18832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
siddarthkay
force-pushed
the
disable-hermes-again
branch
5 times, most recently
from
0ed967a to
f194f5f
Compare
siddarthkay
force-pushed
the
disable-hermes-again
branch
2 times, most recently
from
3da499d to
bd714d5
Compare
jakubgs
approved these changes
Feb 15, 2024
fixes #18831 We update the nix derivation to build android by passing `hermesEnabled` flag which checks the environment variable and if the environment variable is not set we default `hermesEnabled` to `true`. This ensures that `hermes` is disabled for debug builds and enabled for release builds. In this commit we also - rename `nix/mobile/android/release.nix` → `nix/mobile/android/build.nix` since that nix file no longer generates release only builds. - cleanup 2 other env vars and use the `gradle` project format - replace `BUILD_NUMBER` with `verisonCode` for consistency - point to `status-jenkins-lib` branch for env vars change
siddarthkay
force-pushed
the
disable-hermes-again
branch
from
bd714d5 to
24780b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18831
Summary
We update the nix derivation to build android by passing
hermesEnabledflag which checks the environment variable and if the environment variable is not set we defaulthermesEnabledtotrue.This ensures that
hermesis disabled for debug builds and enabled for release builds.In this PR we also
nix/mobile/android/release.nix→nix/mobile/android/build.nixsince that nix file no longer generates release only builds.gradleproject formatBUILD_NUMBERwithverisonCodefor consistencystatus-jenkins-libbranch for env vars changePlatforms
status: ready