fix: make run-ios-device script #18845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
siddarthkay
commented
Feb 15, 2024
siddarthkay
requested review from
yakimant,
smohamedjavid,
alwx,
J-Son89,
OmarBasem,
rasom,
BalogunofAfrica,
briansztamfater,
flexsurfer and
a team
siddarthkay
force-pushed
the
fix-make-ios-deploy-script
branch
from
4e538e3 to
4660c75
Compare
siddarthkay
commented
Feb 16, 2024
ajayesivan
approved these changes
Feb 16, 2024
siddarthkay
force-pushed
the
fix-make-ios-deploy-script
branch
from
4660c75 to
f9c4935
Compare
alwx
approved these changes
Feb 16, 2024
vkjr
approved these changes
Feb 16, 2024
ulisesmac
approved these changes
Feb 16, 2024
smohamedjavid
approved these changes
Feb 19, 2024
jakubgs
approved these changes
Feb 19, 2024
I'm also in favour of the inverted approach, I'll get to this PR in sometime and I still need to rebase this to that approach. |
siddarthkay
force-pushed
the
fix-make-ios-deploy-script
branch
from
1d91919 to
6f82cb0
Compare
siddarthkay
force-pushed
the
fix-make-ios-deploy-script
branch
3 times, most recently
from
c9632b8 to
b048973
Compare
fixes #16310 We used to reply on `react-native cli` and would pass a `--device` flag to deploy the debug variant of `iOS` app on connected `iPhone`. `react-native cli` under the hood uses `ios-deploy` library to achieve this functionality. This showed many weird issues, specifically in locating connected devices and failures at build step with ambiguous error messages. This commit fixes it by using our custom script `run-ios-devices.sh` which does not rely on `ios-deploy`. We use `libimobiledevice` to identify `UDID` of a connected `iPhone`. We use `xcrun devicectl device install app` and `xcrun devicectl device process launch` to install and launch the app. This works well with `Xcode 15` and `iOS 17.x`. We can now remove `ios-deploy` from `iOS` shell and `nix` overlay. we also set up a logs folder and add a Readme - connect your iPhone to your Laptop via a cable - `make run-clojure` - `make run-ios-device` (note: no need to pass device name now)
siddarthkay
force-pushed
the
fix-make-ios-deploy-script
branch
from
b048973 to
43eaa57
Compare
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
fixes #16310 We used to reply on `react-native cli` and would pass a `--device` flag to deploy the debug variant of `iOS` app on connected `iPhone`. `react-native cli` under the hood uses `ios-deploy` library to achieve this functionality. This showed many weird issues, specifically in locating connected devices and failures at build step with ambiguous error messages. This commit fixes it by using our custom script `run-ios-devices.sh` which does not rely on `ios-deploy`. We use `libimobiledevice` to identify `UDID` of a connected `iPhone`. We use `xcrun devicectl device install app` and `xcrun devicectl device process launch` to install and launch the app. This works well with `Xcode 15` and `iOS 17.x`. We can now remove `ios-deploy` from `iOS` shell and `nix` overlay. We also set up a logs folder and add a Readme. ## Review notes - connect your iPhone to your Laptop via a cable - `make run-clojure` - `make run-ios-device` (note: no need to pass device name now) ## Platforms - iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16310
Summary
We used to reply on
react-native cliand would pass a--deviceflag to deploy the debug variant ofiOSapp on connectediPhone.react-native cliunder the hood usesios-deploylibrary to achieve this functionality.This showed many weird issues, specifically in locating connected devices and failures at build step with ambiguous error messages.
This PR fixes it by using our custom script
run-ios-devices.shwhich does not rely onios-deploy.We use
libimobiledeviceto identifyUDIDof a connectediPhone.We use
xcrun devicectl device install appandxcrun devicectl device process launchto install and launch the app.This works well with
Xcode 15andiOS 17.x.We can now remove
ios-deployfromiOSshell andnixoverlay.Review notes
make run-clojuremake run-ios-device(note: no need to pass device name now)
Screen recording
run-ios-devices-1080p.mov
Platforms
status: ready