fix first tap doesn't work when selecting a photo in the gallery #18885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
Parveshdhull
commented
Feb 18, 2024
| @@ -87,7 +87,7 @@ | |||
| [content | |||
| {:insets insets | |||
| :close close | |||
| :scroll-enabled? @scroll-enabled? | |||
| :scroll-enabled? scroll-enabled? | |||
There was a problem hiding this comment.
Bug cause: Early deref rerendered parent and reinitialized states in child components
There was a problem hiding this comment.
Oh so this was the side effect that i was worried about it, my bad. thank you @Parveshdhull
There was a problem hiding this comment.
Hmm but passing a ratom is not ideal, no? Then the component unnecessarily needs to be aware that the prop is a ratom
There was a problem hiding this comment.
We can use some naming convention to clarify that the passed prop is ratom.
| (if (>= (count @selected) constants/max-album-photos) | ||
| (show-photo-limit-toast) | ||
| (swap! selected conj item)))) | ||
| :allow-multiple-presses? true |
There was a problem hiding this comment.
Additional Improvement (more details)
Comment on lines
-94
to
-95
| (rf/dispatch [:photo-selector/get-photos-for-selected-album]) | ||
| (rf/dispatch [:photo-selector/camera-roll-get-albums]) |
There was a problem hiding this comment.
Moved these calls to event
Parveshdhull
force-pushed
the
fix/gallery-first-tap
branch
from
74c5fca to
de63418
Compare
98% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
mohsen-ghafouri
approved these changes
Feb 18, 2024
|
hi @Parveshdhull. thank you for PR. No issues from my side. PR is ready to be merged |
Parveshdhull
force-pushed
the
fix/gallery-first-tap
branch
from
de63418 to
f4d80ba
Compare
Parveshdhull
force-pushed
the
fix/gallery-first-tap
branch
from
f4d80ba to
150fb18
Compare
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18872
status: ready