chore(schema): for user-avatar component #18913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (19)
|
clauxx
requested changes
Feb 20, 2024
Comment on lines
61
to
60
| full-name "Your Name"} | ||
| :as props}] | ||
| (let [full-name (or full-name "Your Name") |
There was a problem hiding this comment.
:or will not handle the case where full-name is passed as nil (e.g. used with (when ...)). I guess would be better to keep it as was, wdyt?
| [quo.components.avatars.user-avatar.style :as style] | ||
| [quo.components.common.no-flicker-image :as no-flicker-image] | ||
| [quo.components.markdown.text :as text] | ||
| [quo.theme] | ||
| [react-native.core :as rn] | ||
| [react-native.fast-image :as fast-image] | ||
| [schema.core :as schema] | ||
| utils.string)) | ||
|
|
||
| (defn initials-avatar |
There was a problem hiding this comment.
I think we can remove the docstring with the addition of the schema
There was a problem hiding this comment.
yes, that is something we should check for too. We should just go and nuke majority of doc strings unless there is specific notes/comments in there 👍
| [:map | ||
| [:full-name {:optional true} [:maybe string?]] | ||
| [:size {:optional true} [:maybe (into [:enum] (keys style/sizes))]] | ||
| [:customization-color [:maybe :schema.common/customization-color]] |
Comment on lines
14
to
17
| [:static? {:optional true} [:maybe :any]] | ||
| [:status-indicator? {:optional true} [:maybe :any]] | ||
| [:online? {:optional true} [:maybe :any]] | ||
| [:ring? {:optional true} [:maybe :any]] |
There was a problem hiding this comment.
would these be booleans given the boolean-sounding names, or are they used differently?
Comment on lines
19
to
23
| [:profile-picture | ||
| [:maybe | ||
| [:or | ||
| string? | ||
| number? | ||
| [:map [:uri string?]] | ||
| [:map [:fn fn?]]]]]]]] |
There was a problem hiding this comment.
we have a schema for this already :schema.common/image-source
yqrashawn
force-pushed
the
schema-for-user-avatar-component
branch
from
3dedf85 to
f6e554b
Compare
|
Thanks for the review @clauxx the doc string is mostly about the |
yqrashawn
force-pushed
the
schema-for-user-avatar-component
branch
3 times, most recently
from
9f7bd5b to
751aad0
Compare
ilmotta
approved these changes
Feb 21, 2024
yqrashawn
force-pushed
the
schema-for-user-avatar-component
branch
from
751aad0 to
ca188d0
Compare
|
Fix component tests several and -(defonce mock-picture {:uri (js/require "../resources/images/mock2/user_picture_male4.png")})
+(defonce mock-picture (resources/mock-images :user-picture-male5))the old one is status-im.common.resources is not allowed in quo, replaced |
Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
schema-for-user-avatar-component
branch
from
ca188d0 to
6cff16d
Compare
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add schema for user-avatar component
status: ready