The wrong validation is applied for entered amount within send assets page #18751 #18937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmilad75
requested review from
ulisesmac,
ilmotta,
briansztamfater,
clauxx and
J-Son89
and removed request for
ulisesmac
Jenkins BuildsClick to see older builds (53)
|
briansztamfater
approved these changes
Feb 21, 2024
ilmotta
approved these changes
Feb 21, 2024
J-Son89
approved these changes
Feb 22, 2024
92% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
|
@VolodLytvynenko Can you please check this PR? |
|
@status-im/mobile-qa Can you please check this PR? |
Hey @mmilad75 Over the next few days, the Mobile QA team will be partially occupied with testing of release 2.27. This may result in some additional delays in PR testing. I believe I can take this PR today, but a bit later |
pavloburykh
force-pushed
the
milad/18751-fix-wrong-validation-in-send-screen
branch
from
8e79f9d to
8af7cc2
Compare
|
Hi @mmilad75 thank you for PR. Take a look please found issue: ISSUE 1: Incorrect validation is applied when the decimal 0 is removed from a value.Steps to Reproduce:
Actual Result:The value is highlighted in red after the last 0 is removed. zerored.mp4Expected Result:The value should not be highlighted in red. |
ISSUE 2: Incorrect validation is applied for pasted amounts.Unfortunately, the issue can't always be reproduced after following the current steps. It seems to occur randomly. hope the logs might help Steps:
Actual result:The pasted value is highlighted as red paste.mp4Expected result:The pasted value is not highlighted as red Devices:
Logs: |
|
@VolodLytvynenko Can you please test again? |
88% of end-end tests have passedFailed tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
|
90% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
|
Hi @mmilad75 thank you for PR. No issues from my side. PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18751
The function that was handling on-delete-press was working with the value of the input before deleting