chore: update ios/logs to logs dir #18974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Jenkins BuildsClick to see older builds (43)
|
siddarthkay
force-pushed
the
move-ios-logs
branch
from
958d6ac to
c26e858
Compare
siddarthkay
force-pushed
the
move-ios-logs
branch
9 times, most recently
from
710ffb8 to
b6befe1
Compare
jakubgs
approved these changes
Feb 27, 2024
jakubgs
reviewed
Feb 27, 2024
siddarthkay
force-pushed
the
move-ios-logs
branch
2 times, most recently
from
ec2f425 to
d135178
Compare
fixes #18915 In this PR #18900 we added a `logs` folder in the root directory and it was discovered that we also have an `ios/logs` folder which the CI uses to generates logs during build time. Its more consistent if we move those logs to the log folder in the root of the repo. This commit fixes that and updates leftover usages.
siddarthkay
force-pushed
the
move-ios-logs
branch
from
d135178 to
5325fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18915
Summary
In this PR #18900 we added a
logsfolder in the root directory and it was discovered that we also have anios/logsfolder which the CI uses to generates logs during build time.Its more consistent if we move those logs to the log folder in the root of the repo.
This PR fixes that and updates leftover usages.
status: ready