Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix channel-action component #19031

Merged
merged 11 commits into from
Mar 14, 2024
Merged

Fix channel-action component #19031

merged 11 commits into from
Mar 14, 2024

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Feb 28, 2024 •
edited
Loading

fixes #19021

Summary

For the channel-action component was fixed according to the design system:

  1. The color when button is pressed in
  2. The big button is using flexbox now instead of fixed width, to assure it looks right on all screens
  3. Separated channel-action from channel-actions, according to the design system
  4. Added preview screen for channel-action

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats

Steps to test

  • Open Status
  • Open a chat
  • Press the channel action (button should have a different color)
  • (or go to preview -> community -> channel-action(s))

status: ready

@clauxx clauxx self-assigned this Feb 28, 2024
@clauxx clauxx force-pushed the cl-19021-chat-action-btn-pressed-in branch from 595b31a to dc02879 Compare February 28, 2024 10:02
@status-im-auto
Copy link
Member

status-im-auto commented Feb 28, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (32)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dc02879 #2 2024-02-28 10:10:21 ~7 min android-e2e 🤖apk 📲
✔️ dc02879 #2 2024-02-28 10:10:30 ~7 min android 🤖apk 📲
✔️ dc02879 #2 2024-02-28 10:13:04 ~10 min ios 📱ipa 📲
✔️ dc02879 #3 2024-02-28 10:39:39 ~3 min tests 📄log
✔️ ea6265c #4 2024-02-29 09:24:09 ~6 min tests 📄log
✔️ e770981 #5 2024-02-29 09:31:32 ~6 min tests 📄log
✔️ e770981 #4 2024-02-29 09:31:34 ~6 min android-e2e 🤖apk 📲
✔️ e770981 #4 2024-02-29 09:32:51 ~7 min android 🤖apk 📲
✔️ b0d803d #6 2024-02-29 09:43:55 ~6 min tests 📄log
✔️ b0d803d #5 2024-02-29 09:45:37 ~8 min android-e2e 🤖apk 📲
✔️ b0d803d #5 2024-02-29 09:45:43 ~8 min android 🤖apk 📲
✔️ b0d803d #5 2024-02-29 09:49:01 ~12 min ios 📱ipa 📲
✔️ 585165d #7 2024-02-29 11:30:33 ~7 min tests 📄log
✔️ 585165d #6 2024-02-29 11:31:57 ~8 min android-e2e 🤖apk 📲
✔️ 585165d #6 2024-02-29 11:31:57 ~8 min android 🤖apk 📲
✔️ 585165d #6 2024-02-29 11:35:34 ~12 min ios 📱ipa 📲
✔️ a4f2dc1 #8 2024-02-29 11:54:12 ~7 min tests 📄log
✔️ a4f2dc1 #7 2024-02-29 11:55:40 ~8 min android 🤖apk 📲
✔️ a4f2dc1 #7 2024-02-29 11:55:40 ~8 min android-e2e 🤖apk 📲
✔️ a4f2dc1 #7 2024-02-29 11:58:03 ~10 min ios 📱ipa 📲
✔️ 71c9e4c #10 2024-03-01 08:28:44 ~6 min tests 📄log
✔️ 71c9e4c #9 2024-03-01 08:30:26 ~7 min android-e2e 🤖apk 📲
✔️ 71c9e4c #9 2024-03-01 08:30:30 ~7 min android 🤖apk 📲
✔️ 71c9e4c #10 2024-03-01 08:36:59 ~13 min ios 📱ipa 📲
❌ 1cef57c #11 2024-03-03 12:24:38 ~6 min ios 📄log
✔️ 1cef57c #11 2024-03-03 12:25:29 ~7 min tests 📄log
✔️ 1cef57c #10 2024-03-03 12:25:38 ~7 min android 🤖apk 📲
✔️ 1cef57c #10 2024-03-03 12:25:47 ~8 min android-e2e 🤖apk 📲
✔️ de95fd0 #12 2024-03-11 09:35:10 ~6 min tests 📄log
✔️ de95fd0 #11 2024-03-11 09:37:06 ~8 min android-e2e 🤖apk 📲
✔️ de95fd0 #11 2024-03-11 09:37:13 ~8 min android 🤖apk 📲
✔️ de95fd0 #12 2024-03-11 09:45:33 ~16 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 600a659 #12 2024-03-14 07:50:42 ~6 min android-e2e 🤖apk 📲
✔️ 600a659 #12 2024-03-14 07:50:57 ~6 min android 🤖apk 📲
✔️ 600a659 #13 2024-03-14 07:52:46 ~8 min ios 📱ipa 📲
✔️ 600a659 #14 2024-03-14 09:06:09 ~4 min tests 📄log
✔️ 2f5a72c #15 2024-03-14 09:39:08 ~6 min tests 📄log
✔️ 2f5a72c #13 2024-03-14 09:40:50 ~8 min android 🤖apk 📲
✔️ 2f5a72c #14 2024-03-14 09:40:50 ~8 min ios 📱ipa 📲
✔️ 2f5a72c #13 2024-03-14 09:40:55 ~8 min android-e2e 🤖apk 📲

@J-Son89
Copy link
Contributor

J-Son89 commented Feb 28, 2024

Thanks for moving these out into separate components 🙏

@clauxx clauxx force-pushed the cl-19021-chat-action-btn-pressed-in branch from e770981 to b0d803d Compare February 29, 2024 09:36
J-Son89
J-Son89 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @clauxx!

@clauxx clauxx force-pushed the cl-19021-chat-action-btn-pressed-in branch from 634ff91 to 71c9e4c Compare March 1, 2024 08:22
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 702850,702786 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/chats/test_public_chat_browsing.py:928: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by the invited member



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 1: Tap on found: Button
    Device 1: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    activity_center/test_activity_center.py:70: in test_activity_center_contact_request_decline
    if self.home_1.pending_contact_request_text.text != '1':
../views/base_element.py:415: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @pavloburykh pavloburykh force-pushed the cl-19021-chat-action-btn-pressed-in branch from 71c9e4c to 1cef57c Compare March 3, 2024 12:17
    @pavloburykh
    Copy link
    Contributor

    @clauxx thanx for the PR. Could you please rebase and resolve existing conflicts so we proceed with testing? Thank you.

    @clauxx
    Copy link
    Member Author

    clauxx commented Mar 11, 2024

    @pavloburykh done 👍

    @qoqobolo qoqobolo self-assigned this Mar 11, 2024
    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 2
Failed tests: 0
Expected to fail tests: 0
Passed tests: 2

    Passed tests (2)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    Thanks for the fix @clauxx!
    @Francesca-G could you also check this and confirm it does look correct now, please?

    Francesca-G
    Francesca-G approved these changes Mar 12, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good ✨

    @clauxx clauxx merged commit aab62dd into develop Mar 14, 2024
    6 checks passed
    @clauxx clauxx deleted the cl-19021-chat-action-btn-pressed-in branch March 14, 2024 09:56
    @flexsurfer flexsurfer mentioned this pull request Mar 15, 2024
    Merged
    @Parveshdhull Parveshdhull mentioned this pull request Mar 28, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @clauxx clauxx

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Fix chat action buttons pressed color
    8 participants
    @clauxx @status-im-auto @J-Son89 @pavloburykh @qoqobolo @flexsurfer @Parveshdhull @Francesca-G