-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show toast after sending contact request #19144
Show toast after sending contact request #19144
Conversation
Jenkins BuildsClick to see older builds (4)
|
67% of end-end tests have passed
Failed tests (15)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (32)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
@status-im/mobile-qa can you review these E2E results please? |
Hey @seanstrom! There are a lot of failures related to problems with our sessions provider. I have triggered re-run, let's wait for new results. |
15% of end-end tests have passed
Failed tests (40)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (7)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
|
Again sessions provider problem. I have triggered re-run one more time |
96% of end-end tests have passed
Failed tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
@seanstrom E2E are okay. Ready for merge. |
Awesome thanks for the help @pavloburykh 🙌 |
474aaf7
to
3ed229a
Compare
3ed229a
to
83b4661
Compare
fixes #19138
Summary
This PR attempts to display a toast notification after confirming to send a contact request.
Platforms
Areas that maybe impacted
Functional
Steps to test
new-contact-ui
feature flag on mobileBefore and after screenshots comparison
Before
Screen.Recording.2024-03-08.at.12.50.44.mov
After
Screen.Recording.2024-03-08.at.12.45.08.mov
status: ready