Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19117] fix: setting over scroll shows gap #19352

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[#19117] fix: setting over scroll shows gap #19352

merged 1 commit into from
Mar 26, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #19117

Summary

Remove gap when user do over scroll

Platforms

  • Android

Before and after screenshots comparison

Before

Screen_recording_20240321_154031.webm

After

Screen_recording_20240321_153613.webm

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Mar 21, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 21, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1b6d931 #1 2024-03-21 12:52:50 ~6 min tests 📄log
✔️ 1b6d931 #1 2024-03-21 12:53:28 ~6 min android 🤖apk 📲
✔️ 1b6d931 #1 2024-03-21 12:54:18 ~7 min android-e2e 🤖apk 📲
✔️ 1b6d931 #1 2024-03-21 13:00:27 ~13 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8104e57 #2 2024-03-26 14:25:50 ~6 min android-e2e 🤖apk 📲
✔️ 8104e57 #2 2024-03-26 14:26:48 ~7 min android 🤖apk 📲
✔️ 8104e57 #2 2024-03-26 14:27:29 ~8 min ios 📱ipa 📲
✔️ 211f49a #3 2024-03-26 16:31:03 ~6 min tests 📄log
✔️ 211f49a #3 2024-03-26 16:31:13 ~6 min android-e2e 🤖apk 📲
✔️ 211f49a #3 2024-03-26 16:31:20 ~7 min android 🤖apk 📲
✔️ 211f49a #3 2024-03-26 16:32:36 ~8 min ios 📱ipa 📲

ajayesivan
ajayesivan approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR: Can we add a bit more space at the bottom to avoid the Jump to button overlapping the logout button when we scroll all the way down? Maybe you have to check with the designers.

@mohsen-ghafouri
Copy link
Contributor Author

@ajayesivan i believe they resolved it in here #19318, it just merged yesterday and not visible in my video.

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 1
Passed tests: 43

IDs of failed tests: 702733,702777,702894,702850 

IDs of expected to fail tests: 703503

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 2: `Text` is `Delivered`
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/chats/test_public_chat_browsing.py:740: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 1-1 chat from blocked user is not removed and messages home is not empty!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:468: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777

    Device 1: Find Button by xpath: //*[@text="Paste"]
    Device 1: Tap on found: Button 

    activity_center/test_activity_center.py:236: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "0x512543419b894307EA979C8d24219c279Be2315B"



    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: close-activity-center
    Device 2: Tap on found: Button 

    activity_center/test_activity_center.py:94: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Pending contact request is not shown on unread notification element on Activity center!



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (43)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @mohsen-ghafouri !

    Please rebase your PR.

    @mariia-skrypnyk mariia-skrypnyk self-assigned this Mar 26, 2024
    @mohsen-ghafouri
    Copy link
    Contributor Author

    Hey @mariia-skrypnyk, done.

    @status-im-auto
    Copy link
    Member

    50% of end-end tests have passed

    Total executed tests: 4
Failed tests: 2
Expected to fail tests: 0
Passed tests: 2

    IDs of failed tests: 702894,702777

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777

    Device 1: Find `Button` by `xpath`: `//*[@text="Paste"]`
    Device 1: Tap on found: Button 

    activity_center/test_activity_center.py:237: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "0x512543419b894307EA979C8d24219c279Be2315B"



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:328: in create_shared_drivers
    raise e
base_test_case.py:318: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Passed tests (2)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @mohsen-ghafouri !
    Thanks for your fix.
    PR can be merged.

    @mohsen-ghafouri mohsen-ghafouri merged commit f075cd0 into develop Mar 26, 2024
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the fix-setting-gap branch March 26, 2024 16:34
    ulisesmac pushed a commit that referenced this pull request Mar 26, 2024
    @mohsen-ghafouri @ulisesmac
    [#19117] fix: setting over scroll shows gap (#19352)
    e5dd184
    mmilad75 pushed a commit that referenced this pull request Apr 2, 2024
    @mohsen-ghafouri @mmilad75
    [#19117] fix: setting over scroll shows gap (#19352)
    a4217d8
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @seanstrom seanstrom Awaiting requested review from seanstrom

    @FFFra FFFra Awaiting requested review from FFFra

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [Android] Gap in the color background when scrolling the profile screen
    6 participants
    @mohsen-ghafouri @status-im-auto @mariia-skrypnyk @Parveshdhull @ajayesivan @ibrkhalil