Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Add methods for fetching and saving addresses #19356

Conversation

shivekkhurana
Copy link
Contributor

@shivekkhurana shivekkhurana commented Mar 21, 2024

Register events for upserting and fetching saved addresses.

This is a part of the Epic to save addresses #18568.

Status: Ready

@status-im-auto
Copy link
Member

status-im-auto commented Mar 21, 2024

Jenkins Builds

Click to see older builds (13)
Commit #️⃣ Finished (UTC) Duration Platform Result
c6ea86a #1 2024-03-21 17:09:47 ~1 min tests 📄log
✔️ c6ea86a #1 2024-03-21 17:14:23 ~6 min android-e2e 🤖apk 📲
✔️ c6ea86a #1 2024-03-21 17:16:11 ~8 min android 🤖apk 📲
✔️ c6ea86a #1 2024-03-21 17:17:12 ~9 min ios 📱ipa 📲
936eb78 #2 2024-03-21 17:59:57 ~1 min tests 📄log
✔️ 936eb78 #2 2024-03-21 18:04:22 ~6 min android-e2e 🤖apk 📲
✔️ 936eb78 #2 2024-03-21 18:04:32 ~6 min android 🤖apk 📲
✔️ 936eb78 #2 2024-03-21 18:06:21 ~8 min ios 📱ipa 📲
2363c6e #3 2024-04-01 14:57:41 ~1 min tests 📄log
0cda55d #4 2024-04-01 15:01:45 ~2 min tests 📄log
✔️ 0cda55d #4 2024-04-01 15:05:02 ~5 min android-e2e 🤖apk 📲
✔️ 0cda55d #4 2024-04-01 15:06:13 ~7 min android 🤖apk 📲
✔️ 0cda55d #4 2024-04-01 15:09:51 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0e26935 #5 2024-04-01 17:32:39 ~4 min tests 📄log
✔️ 0e26935 #5 2024-04-01 17:35:12 ~6 min android-e2e 🤖apk 📲
✔️ 0e26935 #5 2024-04-01 17:35:30 ~6 min android 🤖apk 📲
✔️ 0e26935 #5 2024-04-01 17:38:08 ~9 min ios 📱ipa 📲
✔️ 36e3688 #6 2024-04-02 11:20:20 ~4 min tests 📄log
✔️ 36e3688 #6 2024-04-02 11:22:08 ~6 min android-e2e 🤖apk 📲
✔️ 36e3688 #6 2024-04-02 11:22:56 ~6 min android 🤖apk 📲
✔️ 36e3688 #6 2024-04-02 11:25:05 ~9 min ios 📱ipa 📲

@shivekkhurana shivekkhurana marked this pull request as ready for review April 1, 2024 14:57
@shivekkhurana shivekkhurana force-pushed the shivekkhurana/add-rpc-calls-for-saving-and-retrieving-addresses branch from 2363c6e to 0cda55d Compare April 1, 2024 14:58
src/status_im/contexts/wallet/events.cljs Show resolved Hide resolved
src/status_im/contexts/wallet/events.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/wallet/events.cljs Outdated Show resolved Hide resolved
@shivekkhurana shivekkhurana merged commit a03cc3c into develop Apr 2, 2024
6 checks passed
@shivekkhurana shivekkhurana deleted the shivekkhurana/add-rpc-calls-for-saving-and-retrieving-addresses branch April 2, 2024 11:25
@shivekkhurana
Copy link
Contributor Author

This was merged without manual QA or e2e tests because its a disconnected change. There is no UI or test to test this flow yet.

The next PR will have both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants